From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2502EC43142 for ; Tue, 31 Jul 2018 07:19:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDE68208A2 for ; Tue, 31 Jul 2018 07:19:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="HEDm8ISW"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="JdAdb4VI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDE68208A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731507AbeGaI6W (ORCPT ); Tue, 31 Jul 2018 04:58:22 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56958 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727135AbeGaI6W (ORCPT ); Tue, 31 Jul 2018 04:58:22 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id F3E2460376; Tue, 31 Jul 2018 07:19:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533021568; bh=xAVGpBcNbziTPjVs1lzAFqpwCPO7/ASgUPcDS6bgAS8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=HEDm8ISWiawOJArHnQfBSpzE0Roz31RaSqN2MkN31k4gkYJg1a4nbSHU3uAKOjogD T5KMQ+SMry/f+JpChWCWqLyQO7WO0nx4LRmQY7j19yFl4Q0a5Tq/AHOYtcTNKgAgTx 3Vd9bfWPbkFcpdGaztPOV5I6UKecTWWEPCoZV/RA= Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0A3EC60397; Tue, 31 Jul 2018 07:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533021567; bh=xAVGpBcNbziTPjVs1lzAFqpwCPO7/ASgUPcDS6bgAS8=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=JdAdb4VIpE+0VuWXwqUDKbPJ9KDGbSnQxgyYiNPxfeDUmnIY2LM++GvqS2qcpNN8C slIoar7pl0fwEY87rGi1hMmj4ltXD7kTLaMDGbnoJ/DSej5dnRudtHv2ob1GLL5HUN uehgOttF1I3tzFclQzEFPDeegBVyHkJcnSlCZTzI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0A3EC60397 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] iwlegacy: remove several redundant variables From: Kalle Valo In-Reply-To: <20180711074253.4192-1-colin.king@canonical.com> References: <20180711074253.4192-1-colin.king@canonical.com> To: Colin King Cc: Stanislaw Gruszka , "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180731071927.F3E2460376@smtp.codeaurora.org> Date: Tue, 31 Jul 2018 07:19:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > From: Colin Ian King > > Variables id, unicast, write, conf, a_band, accum_tx and ucode are > assigned a value but it is never read, hence they are redundant and > can be removed. > > Cleans up clang warnings: > warning: variable 'id' set but not used [-Wunused-but-set-variable] > warning: variable 'unicast' set but not used [-Wunused-but-set-variable] > warning: variable 'write' set but not used [-Wunused-but-set-variable] > warning: variable 'conf' set but not used [-Wunused-but-set-variable] > warning: variable 'a_band' set but not used [-Wunused-but-set-variable] > warning: variable 'tx' set but not used [-Wunused-but-set-variable] > warning: variable 'accum_tx' set but not used [-Wunused-but-set-variable] > warning: variable 'ucode' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King > Acked-by: Stanislaw Gruszka Patch applied to wireless-drivers-next.git, thanks. 454127ad36fb iwlegacy: remove several redundant variables -- https://patchwork.kernel.org/patch/10519029/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches