From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3FA1C46463 for ; Tue, 31 Jul 2018 17:49:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78B78208A2 for ; Tue, 31 Jul 2018 17:49:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="rx0YEvIj"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="rx0YEvIj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78B78208A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731564AbeGaTbF (ORCPT ); Tue, 31 Jul 2018 15:31:05 -0400 Received: from node.akkea.ca ([192.155.83.177]:55574 "EHLO node.akkea.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729644AbeGaTbE (ORCPT ); Tue, 31 Jul 2018 15:31:04 -0400 Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 989F4542053; Tue, 31 Jul 2018 17:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1533059380; bh=wXqYBTqxlSTNSDsm/osnmzE24Fsz9qzbQX29UGc92Jo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rx0YEvIjm3Jsqf+UyvWEgK7VGoutwfps2uNrABAHF3qVYJ6iY3FpnsGM4HwtxgBzp 2u2lHo21RPUySOq0gLfchS+8rY+4JnGmzZa5RDbbUBiNJrHhygPoEps9VIuTA5LFj8 WqssfpAuu18mw/G3IB/T94J78SlKpSKHtrC9OcD8= X-Virus-Scanned: Debian amavisd-new at mail.akkea.ca Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o3fcl2pAeq35; Tue, 31 Jul 2018 17:49:40 +0000 (UTC) Received: from midas.localdomain (S0106788a2041785e.cg.shawcable.net [68.144.56.170]) by node.akkea.ca (Postfix) with ESMTPSA id C2EF754204B; Tue, 31 Jul 2018 17:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1533059380; bh=wXqYBTqxlSTNSDsm/osnmzE24Fsz9qzbQX29UGc92Jo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rx0YEvIjm3Jsqf+UyvWEgK7VGoutwfps2uNrABAHF3qVYJ6iY3FpnsGM4HwtxgBzp 2u2lHo21RPUySOq0gLfchS+8rY+4JnGmzZa5RDbbUBiNJrHhygPoEps9VIuTA5LFj8 WqssfpAuu18mw/G3IB/T94J78SlKpSKHtrC9OcD8= From: "Angus Ainslie (Purism)" To: Krzysztof Kozlowski Cc: angus.ainslie@puri.sm, Sebastian Reichel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Angus Ainslie (Purism)" Subject: [PATCH v4 1/4] power: bq25890_charger.c: Add debugging output of failed initialization Date: Tue, 31 Jul 2018 11:49:06 -0600 Message-Id: <20180731174909.9392-2-angus@akkea.ca> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180731174909.9392-1-angus@akkea.ca> References: <20180731174909.9392-1-angus@akkea.ca> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To ease adding a new part variant some debugging is handy. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Angus Ainslie (Purism) --- drivers/power/supply/bq25890_charger.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c index 8e2c41ded171..7f0b3a46c50c 100644 --- a/drivers/power/supply/bq25890_charger.c +++ b/drivers/power/supply/bq25890_charger.c @@ -608,30 +608,40 @@ static int bq25890_hw_init(struct bq25890_device *bq) }; ret = bq25890_chip_reset(bq); - if (ret < 0) + if (ret < 0) { + dev_dbg(bq->dev, "Reset failed %d\n", ret); return ret; + }; /* disable watchdog */ ret = bq25890_field_write(bq, F_WD, 0); - if (ret < 0) + if (ret < 0) { + dev_dbg(bq->dev, "Disabling watchdog failed %d\n", ret); return ret; + }; /* initialize currents/voltages and other parameters */ for (i = 0; i < ARRAY_SIZE(init_data); i++) { ret = bq25890_field_write(bq, init_data[i].id, init_data[i].value); - if (ret < 0) + if (ret < 0) { + dev_dbg(bq->dev, "Writing init data failed %d\n", ret); return ret; + }; } /* Configure ADC for continuous conversions. This does not enable it. */ ret = bq25890_field_write(bq, F_CONV_RATE, 1); - if (ret < 0) + if (ret < 0) { + dev_dbg(bq->dev, "Config ADC failed %d\n", ret); return ret; + }; ret = bq25890_get_chip_state(bq, &state); - if (ret < 0) + if (ret < 0) { + dev_dbg(bq->dev, "Get state failed %d\n", ret); return ret; + }; mutex_lock(&bq->lock); bq->state = state; @@ -767,6 +777,9 @@ static int bq25890_fw_read_u32_props(struct bq25890_device *bq) if (props[i].optional) continue; + dev_err(bq->dev, "Unable to read property %d %s\n", ret, + props[i].name); + return ret; } -- 2.17.1