From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0294CC28CF6 for ; Thu, 2 Aug 2018 01:42:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6C4C20862 for ; Thu, 2 Aug 2018 01:42:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6C4C20862 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732505AbeHBDas (ORCPT ); Wed, 1 Aug 2018 23:30:48 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57584 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730848AbeHBDas (ORCPT ); Wed, 1 Aug 2018 23:30:48 -0400 Received: from localhost (97-120-177-9.ptld.qwest.net [97.120.177.9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B32031009E51A; Wed, 1 Aug 2018 18:42:08 -0700 (PDT) Date: Wed, 01 Aug 2018 18:42:08 -0700 (PDT) Message-Id: <20180801.184208.776886134692058469.davem@davemloft.net> To: ndesaulniers@google.com Cc: natechancellor@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] inet/connection_sock: prefer _THIS_IP_ to current_text_addr From: David Miller In-Reply-To: <20180801215759.103758-1-ndesaulniers@google.com> References: <20180801215759.103758-1-ndesaulniers@google.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 01 Aug 2018 18:42:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nick Desaulniers Date: Wed, 1 Aug 2018 14:57:59 -0700 > - sk, what, when, current_text_addr()); > + sk, what, when, (void *)_THIS_IP_); Is a fugly macro in all caps really better than a function()? I'm really surprised that _THIS_IP_ is being chosen over current_text_addr(), seriously.