From: Mark Brown <broonie@kernel.org>
To: Rohit kumar <rohitkr@codeaurora.org>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz,
srinivas.kandagatla@linaro.org, tiwai@suse.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/4] ASoC: qcom: add sdm845 sound card support
Date: Wed, 1 Aug 2018 11:51:31 +0100 [thread overview]
Message-ID: <20180801105131.GF5509@sirena.org.uk> (raw)
In-Reply-To: <1533114069-16570-5-git-send-email-rohitkr@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
On Wed, Aug 01, 2018 at 02:31:09PM +0530, Rohit kumar wrote:
> --- /dev/null
> +++ b/sound/soc/qcom/sdm845.c
> @@ -0,0 +1,286 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> + */
Please make the entire thing a C++ comment, it makes it look more
intentional.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-08-01 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 9:01 [PATCH v5 0/4] Add support for audio on SDM845 SoC Rohit kumar
2018-08-01 9:01 ` [PATCH v5 1/4] ASoC: qcom: dt-bindings: Add sdm845 machine bindings Rohit kumar
2018-08-01 9:01 ` [PATCH v5 2/4] ASoC: dt-bindings: Update dt binding name for apq8096 Rohit kumar
2018-08-01 9:01 ` [PATCH v5 3/4] ASoC: qcom: Add support to parse common audio device nodes Rohit kumar
2018-08-01 9:01 ` [PATCH v5 4/4] ASoC: qcom: add sdm845 sound card support Rohit kumar
2018-08-01 10:51 ` Mark Brown [this message]
2018-08-01 11:17 ` Applied "ASoC: qcom: add sdm845 sound card support" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801105131.GF5509@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome