From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 323C3C28CF6 for ; Wed, 1 Aug 2018 15:18:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5C54208A4 for ; Wed, 1 Aug 2018 15:18:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5C54208A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fieldses.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389897AbeHAREb (ORCPT ); Wed, 1 Aug 2018 13:04:31 -0400 Received: from fieldses.org ([173.255.197.46]:33992 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389656AbeHAREb (ORCPT ); Wed, 1 Aug 2018 13:04:31 -0400 Received: by fieldses.org (Postfix, from userid 2815) id 61DBB1EF5; Wed, 1 Aug 2018 11:18:20 -0400 (EDT) Date: Wed, 1 Aug 2018 11:18:20 -0400 From: "J. Bruce Fields" To: nixiaoming Cc: jlayton@kernel.org, chuck.lever@oracle.com, trondmy@hammerspace.com, andros@netapp.com, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange_id Message-ID: <20180801151820.GA18338@fieldses.org> References: <20180723015711.27961-1-nixiaoming@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180723015711.27961-1-nixiaoming@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 23, 2018 at 09:57:11AM +0800, nixiaoming wrote: > READ_BUF(8); > dummy = be32_to_cpup(p++); > dummy = be32_to_cpup(p++); > ... > READ_BUF(4); > dummy = be32_to_cpup(p++); > > Assigning value to "dummy" here, but that stored value > is overwritten before it can be used. > At the same time READ_BUF() will re-update the pointer p. > > delete invalid assignment statements Thanks, applying with a minor comment tweak to clarify that we're intentionally not reading these: - /* ssp_window and ssp_num_gss_handles */ + /* ignore ssp_window and ssp_num_gss_handles: */ READ_BUF(8); break; --b. > > Signed-off-by: nixiaoming > Signed-off-by: Chuck Lever > Signed-off-by: Trond Myklebust > --- > fs/nfsd/nfs4xdr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c > index a96843c..375ad4b 100644 > --- a/fs/nfsd/nfs4xdr.c > +++ b/fs/nfsd/nfs4xdr.c > @@ -1392,8 +1392,6 @@ nfsd4_decode_exchange_id(struct nfsd4_compoundargs *argp, > > /* ssp_window and ssp_num_gss_handles */ > READ_BUF(8); > - dummy = be32_to_cpup(p++); > - dummy = be32_to_cpup(p++); > break; > default: > goto xdr_error; > -- > 2.10.1