From: Ivan Bornyakov <brnkv.i1@gmail.com>
To: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
benchan@chromium.org, jnjoseph@google.com, rspringer@google.com,
Ivan Bornyakov <brnkv.i1@gmail.com>
Subject: [PATCH v2] staging: gasket: sysfs: fix potential null dereference
Date: Wed, 1 Aug 2018 21:37:44 +0300 [thread overview]
Message-ID: <20180801183744.30293-1-brnkv.i1@gmail.com> (raw)
In-Reply-To: <20180801180807.GA31510@kroah.com>
Add handling of possible allocation failure.
Reported by smatch:
drivers/staging/gasket/gasket_sysfs.c:105 put_mapping() error: potential null dereference 'files_to_remove'. (kcalloc returns null)
Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com>
---
drivers/staging/gasket/gasket_sysfs.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/gasket/gasket_sysfs.c b/drivers/staging/gasket/gasket_sysfs.c
index a4bfca43cd03..56d62aea5111 100644
--- a/drivers/staging/gasket/gasket_sysfs.c
+++ b/drivers/staging/gasket/gasket_sysfs.c
@@ -101,6 +101,11 @@ static void put_mapping(struct gasket_sysfs_mapping *mapping)
files_to_remove = kcalloc(num_files_to_remove,
sizeof(*files_to_remove),
GFP_KERNEL);
+ if (!files_to_remove) {
+ mutex_unlock(&mapping->mutex);
+ return;
+ }
+
for (i = 0; i < num_files_to_remove; i++)
files_to_remove[i] = mapping->attributes[i].attr;
--
2.16.4
prev parent reply other threads:[~2018-08-01 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 15:23 [PATCH] " Ivan Bornyakov
2018-08-01 18:08 ` Greg KH
2018-08-01 18:37 ` Ivan Bornyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801183744.30293-1-brnkv.i1@gmail.com \
--to=brnkv.i1@gmail.com \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®