From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51707C28CF6 for ; Wed, 1 Aug 2018 18:47:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0781320862 for ; Wed, 1 Aug 2018 18:47:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="KMKJdEts" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0781320862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732186AbeHAUef (ORCPT ); Wed, 1 Aug 2018 16:34:35 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:43674 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbeHAUef (ORCPT ); Wed, 1 Aug 2018 16:34:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UoZYiVydCcfbduqlVoDdyZVfwDaLWYNx7lEdbHuWkFc=; b=KMKJdEtsYX5M3ecbGbC/uGq5S YzUOqWMa3DK7VvhXvAxDmi0omy+Shpxtqc0en0c+dgS9xChGCaHU0f6h+2YJhTwNm2UplMQ4YLirS VDvg/KZWjRhp1wgd5ArrJcPeZnZGxFH0u/FDUq54ARD4yPoJ8dl3vZUhQyHUaDy1rcP1E=; Received: from n2100.armlinux.org.uk ([fd8f:7570:feb6:1:214:fdff:fe10:4f86]:47405) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1fkw9O-00052h-KS; Wed, 01 Aug 2018 19:47:10 +0100 Received: from linux by n2100.armlinux.org.uk with local (Exim 4.90_1) (envelope-from ) id 1fkw9G-0007eQ-UL; Wed, 01 Aug 2018 19:47:03 +0100 Date: Wed, 1 Aug 2018 19:46:59 +0100 From: Russell King - ARM Linux To: Florian Fainelli Cc: Arun Parameswaran , "David S. Miller" , Andrew Lunn , Rob Herring , Mark Rutland , Ray Jui , Scott Branden , Catalin Marinas , Will Deacon , netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 7/8] net: phy: Add support to configure clock in Broadcom iProc mdio mux Message-ID: <20180801184659.GG30658@n2100.armlinux.org.uk> References: <1533146186-8374-1-git-send-email-arun.parameswaran@broadcom.com> <1533146186-8374-8-git-send-email-arun.parameswaran@broadcom.com> <0cc6db4f-7008-0ad3-58d7-9e93060f152f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0cc6db4f-7008-0ad3-58d7-9e93060f152f@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 01, 2018 at 11:40:33AM -0700, Florian Fainelli wrote: > On 08/01/2018 10:56 AM, Arun Parameswaran wrote: > > static int iproc_mdio_wait_for_idle(void __iomem *base, bool result) > > @@ -204,6 +225,20 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev) > > return -ENOMEM; > > } > > > > + md->core_clk = devm_clk_get(&pdev->dev, NULL); > > + if (IS_ERR(md->core_clk)) { > > + if (PTR_ERR(md->core_clk) == -EPROBE_DEFER) > > + return -EPROBE_DEFER; > > + > > + md->core_clk = NULL; > > I would simplify this a bit: > > if (IS_ERR(md->core_clk) && PTR_ERR(md->core_clk) == -EPROBE_DEFER) Even better is: if (md->core_clk == ERR_PTR(-EPROBE_DEFER)) -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up