From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C44C43142 for ; Thu, 2 Aug 2018 22:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 713712152D for ; Thu, 2 Aug 2018 22:17:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 713712152D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728226AbeHCAKu (ORCPT ); Thu, 2 Aug 2018 20:10:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48268 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726229AbeHCAKt (ORCPT ); Thu, 2 Aug 2018 20:10:49 -0400 Received: from localhost (71-36-117-41.ptld.qwest.net [71.36.117.41]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 08CA413CBEA79; Thu, 2 Aug 2018 15:17:41 -0700 (PDT) Date: Thu, 02 Aug 2018 15:17:40 -0700 (PDT) Message-Id: <20180802.151740.166085629835691260.davem@davemloft.net> To: ndesaulniers@google.com Cc: natechancellor@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] inet/connection_sock: prefer _THIS_IP_ to current_text_addr From: David Miller In-Reply-To: References: <20180801215759.103758-1-ndesaulniers@google.com> <20180802.144234.41564686794492805.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 02 Aug 2018 15:17:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nick Desaulniers Date: Thu, 2 Aug 2018 15:10:00 -0700 > On Thu, Aug 2, 2018 at 2:42 PM David Miller wrote: >> >> From: Nick Desaulniers >> Date: Wed, 1 Aug 2018 14:57:59 -0700 >> >> > As part of the effort to reduce the code duplication between _THIS_IP_ >> > and current_text_addr(), let's consolidate callers of >> > current_text_addr() to use _THIS_IP_. >> > >> > Signed-off-by: Nick Desaulniers >> >> I'll ACk this for now: >> >> Acked-by: David S. Miller > > Thank you David. Should you take it into the net tree, can you please add: > > Cc: stable@vger.kernel.org # 4.17, 4.14, 4.9, 4.4 > > to the commit message? This will help us as Nathan stated previously > in this thread. Why in the world is this a stable candidate? It doesn't fix a bug. My understanding is that you are trying to do a consolidation of code and clean things up so that only one interface is used. That means it should, at best, go to the net-next tree. Thank you.