From: Todd Poynor <toddpoynor@gmail.com>
To: Rob Springer <rspringer@google.com>,
John Joseph <jnjoseph@google.com>,
Ben Chan <benchan@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dmitry Torokhov <dtor@chromium.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Todd Poynor <toddpoynor@google.com>
Subject: [PATCH 8/8] Revert "staging: gasket: core: hold reference to pci_dev while used"
Date: Thu, 2 Aug 2018 01:42:45 -0700 [thread overview]
Message-ID: <20180802084245.239689-9-toddpoynor@gmail.com> (raw)
In-Reply-To: <20180802084245.239689-1-toddpoynor@gmail.com>
From: Todd Poynor <toddpoynor@google.com>
There's no need to take an additional reference on the pci_dev structure
for the pointer copy saved in gasket data structures.
This reverts commit 8dd8a48b9a7dae5493494a8603adddfdf1914716.
Reported-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
---
drivers/staging/gasket/gasket_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
index 99994e30b154b..8c5574305f13b 100644
--- a/drivers/staging/gasket/gasket_core.c
+++ b/drivers/staging/gasket/gasket_core.c
@@ -253,7 +253,6 @@ static void gasket_free_dev(struct gasket_dev *gasket_dev)
internal_desc->devs[gasket_dev->dev_idx] = NULL;
mutex_unlock(&internal_desc->mutex);
put_device(gasket_dev->dev);
- pci_dev_put(gasket_dev->pci_dev);
kfree(gasket_dev);
}
@@ -1475,7 +1474,7 @@ static int gasket_pci_probe(struct pci_dev *pci_dev,
ret = gasket_alloc_dev(internal_desc, parent, &gasket_dev, kobj_name);
if (ret)
return ret;
- gasket_dev->pci_dev = pci_dev_get(pci_dev);
+ gasket_dev->pci_dev = pci_dev;
if (IS_ERR_OR_NULL(gasket_dev->dev_info.device)) {
pr_err("gasket: Cannot create %s device %s [ret = %ld]\n",
driver_desc->name, gasket_dev->dev_info.name,
--
2.18.0.597.ga71716f1ad-goog
next prev parent reply other threads:[~2018-08-02 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 8:42 [PATCH 0/8] staging: gasket: cleanups du jour Todd Poynor
2018-08-02 8:42 ` [PATCH 1/8] staging: gasket: apex: enable power save mode by default Todd Poynor
2018-08-02 8:42 ` [PATCH 2/8] staging: gasket: core: print driver version code at registration time Todd Poynor
2018-08-02 8:57 ` Greg Kroah-Hartman
2018-08-02 8:42 ` [PATCH 3/8] staging: gasket: core: move driver loaded log after error cases Todd Poynor
2018-08-02 8:57 ` Greg Kroah-Hartman
2018-08-02 8:42 ` [PATCH 4/8] staging: gasket: core: device register debug log cleanups Todd Poynor
2018-08-02 8:57 ` Greg Kroah-Hartman
2018-08-02 8:42 ` [PATCH 5/8] staging: gasket: core: add subsystem and device info to error logs Todd Poynor
2018-08-02 8:58 ` Greg Kroah-Hartman
2018-08-02 8:42 ` [PATCH 6/8] staging: gasket: remove "reset type" param from framework Todd Poynor
2018-08-02 8:42 ` [PATCH 7/8] staging: gasket: apex: drop reset type param Todd Poynor
2018-08-02 8:42 ` Todd Poynor [this message]
2018-08-02 9:00 ` [PATCH 8/8] Revert "staging: gasket: core: hold reference to pci_dev while used" Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802084245.239689-9-toddpoynor@gmail.com \
--to=toddpoynor@gmail.com \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=dtor@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome