From: Mark Brown <broonie@kernel.org>
To: Akshu Agrawal <akshu.agrawal@amd.com>
Cc: djkurtz@chromium.org, Alexander.Deucher@amd.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
Guenter Roeck <linux@roeck-us.net>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ASoC: AMD: Make ACP->SYSMEM DMA non circular
Date: Thu, 2 Aug 2018 10:56:17 +0100 [thread overview]
Message-ID: <20180802095617.GC9117@sirena.org.uk> (raw)
In-Reply-To: <1533192134-11626-1-git-send-email-akshu.agrawal@amd.com>
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
On Thu, Aug 02, 2018 at 12:11:54PM +0530, Akshu Agrawal wrote:
> In capture case we don't want ACP to SYSMEM dma
> to be circular. This is because if an in place DSP
> filter is applied to captured output then circular DMA
> can overwrite the filter value with stale data.
Isn't that just a problem with userspace not giving itself enough buffer
to get the in place processing done before we loop round again. This
will simply change the type of error, it won't actually fix anything
AFAICT but perhaps I'm missing something.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-08-02 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 6:41 Akshu Agrawal
2018-08-02 6:41 ` [PATCH 2/3] ASoC: AMD: Modified DMA pointer for capture Akshu Agrawal
2018-08-02 6:41 ` [PATCH 3/3] ASoC: AMD: Set delay value for the capture case Akshu Agrawal
2018-08-02 9:56 ` Mark Brown [this message]
2018-08-06 7:26 ` [PATCH 1/3] ASoC: AMD: Make ACP->SYSMEM DMA non circular Agrawal, Akshu
2018-08-06 7:27 Akshu Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802095617.GC9117@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Alexander.Deucher@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=akshu.agrawal@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=djkurtz@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®