From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE09FC43142 for ; Thu, 2 Aug 2018 19:06:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 679E121566 for ; Thu, 2 Aug 2018 19:06:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="isPHnxcn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 679E121566 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726971AbeHBU62 (ORCPT ); Thu, 2 Aug 2018 16:58:28 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:51188 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726177AbeHBU62 (ORCPT ); Thu, 2 Aug 2018 16:58:28 -0400 Received: by mail-wm0-f67.google.com with SMTP id s12-v6so3712208wmc.0; Thu, 02 Aug 2018 12:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=AuEDrPUWVFEyI/sFUlA330R5I1ih4ClX9JUUhklaX04=; b=isPHnxcn7fLS8xlIt6sY9qN5Wf5WnQl1bK2KFH3B4fkSEQPNsiumzvE6QjTVj7PWJE w3IMu1zkJ8e/IJx4EtjE8v5aNCaAYqlpXByyZghCTGLPQYRnfHb3/W7tv2AjQ8MHlIes dHTpCeJAwFcjZl2qB9z34XrgEQOZI/YQyIJKqvT7B2ofRQ9v9rGR+vbHDPKISkmdR9Gg TNb6Fi7F+93i9N7Xp23NTa+VJMX64RPvD54Yjr7smllHhY+bjbRBN0vTuLhdoJX4iM6q tCu4K8nTxxtxpK7lbxV5CoagVse0MKvU9Mi59eM13TZfO+Sj7FcPhAR34MB0/W/xJwhB 3dIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=AuEDrPUWVFEyI/sFUlA330R5I1ih4ClX9JUUhklaX04=; b=Tbl84qOoxzZwprnTjIEsy2TjfpYKUiuiwtdIwQprfGif+eDy1AWbxwz3Ri7WBfzW6l HXjijZF+GlGDt3WRGvuZlwxk/7UkN/I78f8IgatjWSJ1aO5Kk0bL2+/ryxJH2lqGqtPy N3f+nKoNKIamcTCS9UqPh6eyiZZWqzSZ/McTeYr7UaTmDDw/L9WvesyfePdw7+InjC77 YrT/kokRdlpCbVxAnG+u3VTewMjyXMygp6HNxJu0LAMlo0KxAuQJnvdRMhpJzFCHubK2 RRmwaF/6bkDTUqOvZ/DiLjEqIXiK/4+J5f++nsAYH+9nrQ4S9SSzZXu/nqR9dJ0sZbfU NKsQ== X-Gm-Message-State: AOUpUlFTsg5UR1ow+iGsdEAgQIjwGeB3TlyYhvMzTfLANk4hjGwupH3c mSM+ALn19OidP5pcjodRaPI= X-Google-Smtp-Source: AAOMgpcyBKLtdpyBMcUkVwK7IoB4Ljgl9sdnRHmq1IUymqIuogkJVxO9I1xBXfH7RfR3Qmn7GtN5IA== X-Received: by 2002:a1c:8c12:: with SMTP id o18-v6mr2701925wmd.120.1533236759173; Thu, 02 Aug 2018 12:05:59 -0700 (PDT) Received: from sch.bme.hu (ecklm-pi.sch.bme.hu. [152.66.179.182]) by smtp.gmail.com with ESMTPSA id y11-v6sm3170351wrt.4.2018.08.02.12.05.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 12:05:58 -0700 (PDT) Date: Thu, 2 Aug 2018 21:05:57 +0200 From: =?utf-8?B?TcOhdMOp?= Eckl To: Randy Dunlap Cc: Stephen Rothwell , Linux-Next Mailing List , Linux Kernel Mailing List , "netdev@vger.kernel.org" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, pablo@netfilter.org Subject: Re: linux-next: Tree for Aug 2 (netfilter: tproxy) Message-ID: <20180802190557.sha6wer6gkdgrd6i@sch.bme.hu> References: <20180802193111.346fdde9@canb.auug.org.au> <0185f82e-4bf5-6c6c-a131-ba2c0197c9a0@infradead.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nwyw3czl35l47w5e" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0185f82e-4bf5-6c6c-a131-ba2c0197c9a0@infradead.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nwyw3czl35l47w5e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Randy, Thanks for reporting! Please find the patch attached. Regards, Mate On Thu, Aug 02, 2018 at 09:28:16AM -0700, Randy Dunlap wrote: > On 08/02/2018 02:31 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20180801: > > > > on i386: > > ../net/netfilter/nft_tproxy.c: In function 'nft_tproxy_init': > ../net/netfilter/nft_tproxy.c:237:3: error: implicit declaration of function 'nf_defrag_ipv6_enable' [-Werror=implicit-function-declaration] > err = nf_defrag_ipv6_enable(ctx->net); > > > Full randconfig file is attached. > > Reported-by: Randy Dunlap > > -- > ~Randy --nwyw3czl35l47w5e Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-netfilter-nft_tproxy-Add-missing-config-check.patch" Content-Transfer-Encoding: 8bit >From 2c3a7d3209ed5e539ecd69192fc0f4186fdc7d99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Eckl?= Date: Thu, 2 Aug 2018 20:46:13 +0200 Subject: [PATCH] netfilter: nft_tproxy: Add missing config check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A config check was missing form the code when using nf_defrag_ipv6_enable with NFT_TPROXY != n and NF_DEFRAG_IPV6 = n and this caused the following error in case of : ../net/netfilter/nft_tproxy.c: In function 'nft_tproxy_init': ../net/netfilter/nft_tproxy.c:237:3: error: implicit declaration of function +'nf_defrag_ipv6_enable' [-Werror=implicit-function-declaration] err = nf_defrag_ipv6_enable(ctx->net); This patch adds a check for NF_TABLES_IPV6 when NF_DEFRAG_IPV6 is selected by Kconfig. Reported-by: Randy Dunlap Fixes: 4ed8eb6570a4 ("netfilter: nf_tables: Add native tproxy support") Signed-off-by: Máté Eckl --- net/netfilter/nft_tproxy.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/netfilter/nft_tproxy.c b/net/netfilter/nft_tproxy.c index c6845f7baa08..eff99dffc842 100644 --- a/net/netfilter/nft_tproxy.c +++ b/net/netfilter/nft_tproxy.c @@ -234,9 +234,11 @@ static int nft_tproxy_init(const struct nft_ctx *ctx, err = nf_defrag_ipv4_enable(ctx->net); if (err) return err; +#if IS_ENABLED(CONFIG_NF_TABLES_IPV6) err = nf_defrag_ipv6_enable(ctx->net); if (err) return err; +#endif break; default: return -EOPNOTSUPP; -- ecklm --nwyw3czl35l47w5e--