From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70142C43142 for ; Fri, 3 Aug 2018 01:46:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2AC872170A for ; Fri, 3 Aug 2018 01:46:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AC872170A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732286AbeHCDjy (ORCPT ); Thu, 2 Aug 2018 23:39:54 -0400 Received: from mga07.intel.com ([134.134.136.100]:55287 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729765AbeHCDjy (ORCPT ); Thu, 2 Aug 2018 23:39:54 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2018 18:46:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,437,1526367600"; d="scan'208";a="60057319" Received: from ning-debian.sh.intel.com ([10.239.16.9]) by fmsmga008.fm.intel.com with ESMTP; 02 Aug 2018 18:45:46 -0700 From: Zhang Ning To: gregkh@linuxfoundation.org, kstewart@linuxfoundation.org, pombredanne@nexb.com, yamada.masahiro@socionext.com, markus@trippelsdorf.de, linux-kernel@vger.kernel.org Cc: Zhang Ning , Li@vger.kernel.org, Ting Subject: [PATCH] firmware: make sure builtin firmware is page alignment Date: Fri, 3 Aug 2018 09:45:21 +0800 Message-Id: <20180803014521.21527-1-ning.a.zhang@intel.com> X-Mailer: git-send-email 2.18.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org when firmware is in filesystem, request_firmware will load it, and copy it to vmalloc memory, that is page align memory. but when firmware is builtin, it is 8 bytes or 4 bytes alignment. make sure builtin firmware is page algnment, that can simplify algorithm to handle firmware. Signed-off-by: Zhang Ning Signed-off-by: Li, Ting --- firmware/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/firmware/Makefile b/firmware/Makefile index 29641383e136..d7bfce56378f 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -16,10 +16,11 @@ quiet_cmd_fwbin = MK_FW $@ firmware/%.gen.S,%,$@))))"; \ ASM_WORD=$(if $(CONFIG_64BIT),.quad,.long); \ ASM_ALIGN=$(if $(CONFIG_64BIT),3,2); \ + ASM_FW_ALIGN=12; \ PROGBITS=$(if $(CONFIG_ARM),%,@)progbits; \ echo "/* Generated by firmware/Makefile */" > $@;\ echo " .section .rodata" >>$@;\ - echo " .p2align $${ASM_ALIGN}" >>$@;\ + echo " .p2align $${ASM_FW_ALIGN}" >>$@;\ echo "_fw_$${FWSTR}_bin:" >>$@;\ echo " .incbin \"$(2)\"" >>$@;\ echo "_fw_end:" >>$@;\ -- 2.18.0