From: David Miller <davem@davemloft.net>
To: dima@arista.com
Cc: linux-kernel@vger.kernel.org, natechancellor@gmail.com,
herbert@gondor.apana.org.au, steffen.klassert@secunet.com,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCHv2] netlink: Don't shift on 64 for ngroups
Date: Sat, 04 Aug 2018 17:53:42 -0700 (PDT) [thread overview]
Message-ID: <20180804.175342.887624852314321631.davem@davemloft.net> (raw)
In-Reply-To: <20180805003553.11104-1-dima@arista.com>
From: Dmitry Safonov <dima@arista.com>
Date: Sun, 5 Aug 2018 01:35:53 +0100
> It's legal to have 64 groups for netlink_sock.
>
> As user-supplied nladdr->nl_groups is __u32, it's possible to subscribe
> only to first 32 groups.
>
> The check for correctness of .bind() userspace supplied parameter
> is done by applying mask made from ngroups shift. Which broke Android
> as they have 64 groups and the shift for mask resulted in an overflow.
>
> Fixes: 61f4b23769f0 ("netlink: Don't shift with UB on nlk->ngroups")
> Reported-and-Tested-by: Nathan Chancellor <natechancellor@gmail.com>
> Signed-off-by: Dmitry Safonov <dima@arista.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2018-08-05 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 0:35 Dmitry Safonov
2018-08-05 0:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180804.175342.887624852314321631.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dima@arista.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®