From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Tino Lehnig <tino.lehnig@contabo.de>,
stable@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature
Date: Mon, 6 Aug 2018 08:15:44 +0900 [thread overview]
Message-ID: <20180805231544.GA209075@rodete-desktop-imager.corp.google.com> (raw)
In-Reply-To: <20180803162818.8c4719232d6dfece21ebea30@linux-foundation.org>
Hi Andrew,
On Fri, Aug 03, 2018 at 04:28:18PM -0700, Andrew Morton wrote:
> On Fri, 3 Aug 2018 11:51:43 +0900 Minchan Kim <minchan@kernel.org> wrote:
>
> > > Is it legitimate to be altering the bdi capabilities at this level? Or
> > > is this hacky?
> >
> > Most of device's bdi capability seems to be static but there are few drivers
> > which can change capability. For example, BDI_CAP_STABLE_WRITES
> >
> > drivers/scsi/iscsi_tcp.c
> > drivers/md/raid5.c
> >
> > I believe it's driver itself advertisement stuff so I hope it's not hack.
>
> The bdi is per-disk (per-queue). So if zram changes the bdi for a
> particular partition then it is accidentally mucking with the other
> partitions as well, and it shouldn't do that. At least, I think that's
Aha, I didn't know that. Thanks for the heads up.
However, I think zram doesn't support partitioning due to lacking of
probe feature via blk_register_region. ;-)
prev parent reply other threads:[~2018-08-05 23:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 5:11 Minchan Kim
2018-08-02 21:13 ` Andrew Morton
2018-08-03 2:39 ` Sergey Senozhatsky
2018-08-03 2:52 ` Sergey Senozhatsky
2018-08-03 3:00 ` Minchan Kim
2018-08-03 4:13 ` Sergey Senozhatsky
2018-08-03 4:51 ` Minchan Kim
2018-08-03 5:23 ` Sergey Senozhatsky
2018-08-03 5:45 ` Sergey Senozhatsky
2018-08-03 2:51 ` Minchan Kim
2018-08-03 23:28 ` Andrew Morton
2018-08-05 23:15 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180805231544.GA209075@rodete-desktop-imager.corp.google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tino.lehnig@contabo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®