From: David Miller <davem@davemloft.net>
To: poros@redhat.com
Cc: netdev@vger.kernel.org, ivecera@redhat.com,
sathya.perla@broadcom.com, ajit.khaparde@broadcom.com,
sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use Kconfig flag to remove support of deprecated BE2/BE3 adapters
Date: Mon, 06 Aug 2018 13:46:20 -0700 (PDT) [thread overview]
Message-ID: <20180806.134620.124956510948789350.davem@davemloft.net> (raw)
In-Reply-To: <20180806121230.23690-1-poros@redhat.com>
From: Petr Oros <poros@redhat.com>
Date: Mon, 6 Aug 2018 14:12:28 +0200
> Add flags to remove support of deprecated BE2/BE3 adapters.
> BE2 disable will reduce .ko size by 2kb and BE3 by 3kb.
> Disable both will reduce .ko size by 9kb.
>
> With dissabled support is also removed coresponding PCI IDs
> and codepath with [BE2|BE3|BEx]_chip checks.
>
> New help style in Kconfig
>
> Signed-off-by: Petr Oros <poros@redhat.com>
Sorry, I'm not too hot about this.
Imagine being one of the people who has one of these cards.
Pulling out detection and working'ness of devices from a driver
is a big step backwards, and I'm sorry I will don't want to be
part of something that facilitates this.
The S390 folks tried something similar in the past and I reject
those changes too.
Thanks.
next prev parent reply other threads:[~2018-08-06 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 12:12 Petr Oros
2018-08-06 13:03 ` Ivan Vecera
2018-08-06 16:21 ` Christoph Hellwig
2018-08-07 11:35 ` Ivan Vecera
2018-08-06 20:46 ` David Miller [this message]
2018-08-07 11:44 ` Ivan Vecera
2018-08-07 20:21 ` David Miller
2018-08-07 20:42 ` Ivan Vecera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806.134620.124956510948789350.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@broadcom.com \
--cc=ivecera@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=poros@redhat.com \
--cc=sathya.perla@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®