From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Leonardo Brás" <leobras.c@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] staging: fbtft: Changes udelay(n) to usleep_range(n, n + 1). - Style
Date: Tue, 7 Aug 2018 09:49:45 +0300 [thread overview]
Message-ID: <20180807064944.6n5cofacsbtbqsxr@mwanda> (raw)
In-Reply-To: <4822329bce6607da8bd434a083724569b61210ff.1533614243.git.leobras.c@gmail.com>
We need a commit message here.
On Tue, Aug 07, 2018 at 01:04:56AM -0300, Leonardo Brás wrote:
> Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
> ---
> drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-
> drivers/staging/fbtft/fb_ra8875.c | 4 ++--
> drivers/staging/fbtft/fb_tinylcd.c | 2 +-
> drivers/staging/fbtft/fb_upd161704.c | 19 +++++++++----------
> drivers/staging/fbtft/fb_watterott.c | 4 ++--
> 5 files changed, 15 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
> index f6f30f5bf15a..c936950ce56d 100644
> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
> @@ -85,7 +85,7 @@ static void reset(struct fbtft_par *par)
> dev_dbg(par->info->device, "%s()\n", __func__);
>
> gpio_set_value(par->gpio.reset, 0);
> - udelay(20);
> + usleep_range(20, 21);
Is this really the right range? It feels tight.
> gpio_set_value(par->gpio.reset, 1);
> mdelay(120);
regards,
dan carpenter
next prev parent reply other threads:[~2018-08-07 6:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 4:04 [PATCH 00/11] Style Fixes on fbtft Leonardo Brás
2018-08-07 4:04 ` [PATCH 01/11] staging: fbtft: Changes udelay(n) to usleep_range(n, n + 1). - Style Leonardo Brás
2018-08-07 6:49 ` Dan Carpenter [this message]
2018-08-07 4:05 ` [PATCH 02/11] staging: fbtft: Puts macro arguments in parenthesis to avoid precedence issues " Leonardo Brás
2018-08-07 4:05 ` [PATCH 03/11] staging: fbtft: Fixes some alignment and line > 80 char " Leonardo Brás
2018-08-07 8:05 ` Dan Carpenter
2018-08-07 4:05 ` [PATCH 04/11] staging: fbtft: Adjust some empty-line problems " Leonardo Brás
2018-08-07 4:06 ` [PATCH 06/11] staging: fbtft: Fixes some defines styles " Leonardo Brás
2018-08-07 4:06 ` [PATCH 07/11] staging: fbtft: Includes description to mutex and spinlock " Leonardo Brás
2018-08-07 4:07 ` [PATCH 08/11] staging: fbtft: Add spaces around / " Leonardo Brás
2018-08-07 4:07 ` [PATCH 09/11] staging: fbtft: Corrects long index line " Leonardo Brás
2018-08-07 4:07 ` [PATCH 10/11] staging: fbtft: Replaces (1 << n) for macro BIT(n) " Leonardo Brás
2018-08-07 4:07 ` [PATCH 11/11] staging: fbtft: Includes parenthesis around macro parameters and avoids multiple usage of macro parameter " Leonardo Brás
2018-08-07 7:46 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807064944.6n5cofacsbtbqsxr@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=leobras.c@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®