From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D863C4646D for ; Wed, 8 Aug 2018 09:31:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32F6621722 for ; Wed, 8 Aug 2018 09:31:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="JfIGemck" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32F6621722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbeHHLut (ORCPT ); Wed, 8 Aug 2018 07:50:49 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:43106 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726625AbeHHLus (ORCPT ); Wed, 8 Aug 2018 07:50:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rD6Yec3SqKiNs6yIvO80+7/h9G272JnHrr1EKGDmeOA=; b=JfIGemckpjmKkn8Zqob9jt6q4 8wpAIkCdk03LILwnyJaL+QnU/goF0635UBsXdXgSyWROzDkOZ4BD6nDNtvZ7Pnl+RYdS2LONEtM55 p8FLPmspjShn0cD4XLldAsjgHh66+MGzwHjXRzw9k68efjADnepHxKRZ5ykYaL7tAbEdk=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fnKom-0001cM-Kx; Wed, 08 Aug 2018 09:31:48 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 0CD0D112433C; Wed, 8 Aug 2018 10:31:48 +0100 (BST) Date: Wed, 8 Aug 2018 10:31:48 +0100 From: Mark Brown To: Baolin Wang Cc: Rob Herring , Mark Rutland , Orson Zhai , Chunyan Zhang , lanqing.liu@spreadtrum.com, linux-spi@vger.kernel.org, DTML , LKML Subject: Re: [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860 Message-ID: <20180808093148.GA9346@sirena.org.uk> References: <64681bf903104c8a02f118294e616e2a12a5ebe4.1533638405.git.baolin.wang@linaro.org> <99befd2badc4dffb59662fca1e11d79f18b64755.1533638405.git.baolin.wang@linaro.org> <20180807142408.GB7958@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline In-Reply-To: X-Cookie: Should I do my BOBBIE VINTON medley? User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 08, 2018 at 10:45:33AM +0800, Baolin Wang wrote: > On 7 August 2018 at 22:24, Mark Brown wrote: > > On Tue, Aug 07, 2018 at 06:43:38PM +0800, Baolin Wang wrote: > >> + bits_per_word = bits_per_word > 16 ? round_up(bits_per_word, 16) : > >> + round_up(bits_per_word, 8); > > Please > Sorry I did not get your points here, could you elaborate on? Sorry, missed the actual comment there - use normal if statements rather than the ternery operator, it's easier to read. --UlVJffcvxoiEqYs2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAltquIEACgkQJNaLcl1U h9D8Lwf+J5prKQ102tAnrwIbX+bnTbGLWbzHy/xe9I5LurjAiiD71625mnUJpUa6 wySqLkDVivSopvk0Kep3i6i1M7CGRHHJucqFNe631u8ZahigQ9yE9CM8IVQxkqEY vfg6FCLyGxqGk5BCbjOHnqHDznkCsKVLYRPyp5QrPo8OxX1IvjZASba2Unksiyov ivsRL8LCBFHtzynR07kIvjMDYkulC6E0H2VsQE8fNAbrOfTd+WD4Ht8L2gj0PY+t GWBUX5H+wQmYNo+aSrwartUsw9SpHF8/O6yk1X9nIOlOEWC64FF3YGw87EcP4HOM XA7NKASPkS8NEYZR3pDoOR3OeyViqw== =rz+7 -----END PGP SIGNATURE----- --UlVJffcvxoiEqYs2--