From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30460C46464 for ; Thu, 9 Aug 2018 14:18:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C554E21E21 for ; Thu, 9 Aug 2018 14:18:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C554E21E21 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732341AbeHIQnv (ORCPT ); Thu, 9 Aug 2018 12:43:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:53194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731176AbeHIQnv (ORCPT ); Thu, 9 Aug 2018 12:43:51 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3DCE521E21; Thu, 9 Aug 2018 14:18:44 +0000 (UTC) Date: Thu, 9 Aug 2018 10:18:42 -0400 From: Steven Rostedt To: Colin King Cc: Ingo Molnar , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ftrace: remove unused pointer ftrace_swapper_pid Message-ID: <20180809101842.5994fd21@gandalf.local.home> In-Reply-To: <20180809125609.13142-1-colin.king@canonical.com> References: <20180809125609.13142-1-colin.king@canonical.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Aug 2018 13:56:09 +0100 Colin King wrote: > From: Colin Ian King > > Pointer ftrace_swapper_pid is defined but is never used hence it is > redundant and can be removed. The use of this variable was removed > in commit 345ddcc882d8 ("ftrace: Have set_ftrace_pid use the bitmap > like events do"). > > Cleans up clang warning: > warning: 'ftrace_swapper_pid' defined but not used [-Wunused-const-variable=] Thanks, applied! -- Steve > > Signed-off-by: Colin Ian King > --- > kernel/trace/ftrace.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index caf9cbf35816..2cc008cfbd4f 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -1049,8 +1049,6 @@ static __init void ftrace_profile_tracefs(struct dentry *d_tracer) > } > #endif /* CONFIG_FUNCTION_PROFILER */ > > -static struct pid * const ftrace_swapper_pid = &init_struct_pid; > - > #ifdef CONFIG_FUNCTION_GRAPH_TRACER > static int ftrace_graph_active; > #else