From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA97C4646D for ; Sat, 11 Aug 2018 20:55:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5743B21A0B for ; Sat, 11 Aug 2018 20:55:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5743B21A0B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727698AbeHKXay (ORCPT ); Sat, 11 Aug 2018 19:30:54 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:47278 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727475AbeHKXay (ORCPT ); Sat, 11 Aug 2018 19:30:54 -0400 Received: from localhost (71-36-117-41.ptld.qwest.net [71.36.117.41]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 64B48143E3F22; Sat, 11 Aug 2018 11:28:54 -0700 (PDT) Date: Sat, 11 Aug 2018 11:28:53 -0700 (PDT) Message-Id: <20180811.112853.2039117789072425372.davem@davemloft.net> To: gustavo@embeddedor.com Cc: richardcochran@gmail.com, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: dp83640: Mark expected switch fall-throughs From: David Miller In-Reply-To: <20180809150824.GA15116@embeddedor.com> References: <20180809150824.GA15116@embeddedor.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 11 Aug 2018 11:28:54 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Thu, 9 Aug 2018 10:08:24 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case, I replaced the code comment at the > top of the switch statement with a proper "fall through" annotation for > each case, which is what GCC is expecting to find. > > Addresses-Coverity-ID: 1056542 ("Missing break in switch") > Addresses-Coverity-ID: 1339579 ("Missing break in switch") > Addresses-Coverity-ID: 1369526 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Applied, thanks.