From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE10C46460 for ; Tue, 14 Aug 2018 08:43:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F0582170D for ; Tue, 14 Aug 2018 08:43:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F0582170D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731222AbeHNL3u (ORCPT ); Tue, 14 Aug 2018 07:29:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55854 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727689AbeHNL3t (ORCPT ); Tue, 14 Aug 2018 07:29:49 -0400 Received: from localhost (unknown [194.244.16.108]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 2A9BDC74; Tue, 14 Aug 2018 08:43:38 +0000 (UTC) Date: Tue, 14 Aug 2018 10:43:35 +0200 From: gregkh To: Arnd Bergmann Cc: ajay.kathat@microchip.com, aditya.shankar@microchip.com, ganesh.krishna@microchip.com, driverdevel , linux-wireless , Linux Kernel Mailing List Subject: Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module" Message-ID: <20180814084335.GB7208@kroah.com> References: <20180813212108.2442868-1-arnd@arndb.de> <20180814105237.64b01528@ajaysk-VirtualBox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 14, 2018 at 10:34:27AM +0200, Arnd Bergmann wrote: > On Tue, Aug 14, 2018 at 7:22 AM Ajay Singh wrote: > > > > Hi Arnd, > > > > On Mon, 13 Aug 2018 23:20:33 +0200 > > Arnd Bergmann wrote: > > > > > The TODO item named "make spi and sdio components coexist in one > > > build" was apparently addressed a long time ago, but never removed > > > from the TODO file. However, the new patch that tries to address it > > > actually makes it worse again by duplicating the common parts of the > > > driver into two separate modules rather than sharing them. This also > > > introduces a build regression when one of the two is built-in while > > > the other is a loadable module: > > > > Thanks for sharing your inputs and submitting patch. > > I have also submitted a patch to address the compilation error[1]. > > We can ignore my patch and proceed with your changes. > > > > [1].https://patchwork.kernel.org/patch/10563873/ > > That patch seems useful regardless, as it removes dead code, > but I'd still prefer to revert the 9abc44ba4e2f ("staging: wilc1000: > fix TODO to compile spi and sdio components in single module") > commit for the other reasons I explained. I agree, I'll queue it up soon, I have other patches to get to Linus first. thanks, greg k-h