mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf auxtrace: Fix queue resize
Date: Tue, 14 Aug 2018 19:07:02 -0300	[thread overview]
Message-ID: <20180814220702.GB32497@kernel.org> (raw)
In-Reply-To: <20180814084608.6563-1-adrian.hunter@intel.com>

Em Tue, Aug 14, 2018 at 11:46:08AM +0300, Adrian Hunter escreveu:
> When the number of queues grows beyond 32, the array of queues is resized
> but not all members were being copied. Fix by also copying 'tid', 'cpu' and
> 'set'.

Thanks, applied.
 
> Fixes: e502789302a6e ("perf auxtrace: Add helpers for queuing AUX area tracing data")
> Cc: stable@vger.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>  tools/perf/util/auxtrace.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> index ae8c37b219c9..db1511359c5e 100644
> --- a/tools/perf/util/auxtrace.c
> +++ b/tools/perf/util/auxtrace.c
> @@ -203,6 +203,9 @@ static int auxtrace_queues__grow(struct auxtrace_queues *queues,
>  	for (i = 0; i < queues->nr_queues; i++) {
>  		list_splice_tail(&queues->queue_array[i].head,
>  				 &queue_array[i].head);
> +		queue_array[i].tid = queues->queue_array[i].tid;
> +		queue_array[i].cpu = queues->queue_array[i].cpu;
> +		queue_array[i].set = queues->queue_array[i].set;
>  		queue_array[i].priv = queues->queue_array[i].priv;
>  	}
>  
> -- 
> 2.17.1

  reply	other threads:[~2018-08-14 22:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14  8:46 Adrian Hunter
2018-08-14 22:07 ` Arnaldo Carvalho de Melo [this message]
2018-08-18 11:58 ` [tip:perf/urgent] " tip-bot for Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180814220702.GB32497@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome