From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_MED, UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 625C6C4321D for ; Thu, 16 Aug 2018 09:31:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E19DD2148E for ; Thu, 16 Aug 2018 09:31:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=waldekranz-com.20150623.gappssmtp.com header.i=@waldekranz-com.20150623.gappssmtp.com header.b="xnsgcI5h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E19DD2148E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=waldekranz.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390505AbeHPM2P (ORCPT ); Thu, 16 Aug 2018 08:28:15 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:33232 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731376AbeHPM2P (ORCPT ); Thu, 16 Aug 2018 08:28:15 -0400 Received: by mail-lf1-f65.google.com with SMTP id u14-v6so2925403lfu.0 for ; Thu, 16 Aug 2018 02:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=waldekranz-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization; bh=1g4W4DPaKo8EPB3Yox5xayg40Vuqf10sRmiBShKv2lk=; b=xnsgcI5h2HGvV3WSHfrPncUurTtTTGHpaW/85eJfbzThiuBqIc39gt1j4GimLNdj51 QxnVaSwZGnaD14yNSEtvSxLVpBy8u+fDHApdxfEh+PY48OTHUbdrz7xhF/DfrwD2ztX8 j2hZ3wywf/wiInKe0lzkY2mj3js6hSXzxNu/PlBC/9rBcog83BOWasHXi4iNUB2PkXk5 tukrvTedg2xQGfLU/Bag6lku+i1j7vjaZ6TP81f9sYGMmLDJJCLmhGCuJmR5E6X1luGi DYYNILjA21UpipfjgzbCuNd3LV3Vhny+iU2bayV6zB0YQQzQfO3PiOlou3Jm4mpVrT1E SJTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization; bh=1g4W4DPaKo8EPB3Yox5xayg40Vuqf10sRmiBShKv2lk=; b=YPHBkmMs3OhEU0VC/YN08i3SWGnP051o3j/qo/jPpHUVxeOxX/3Bh6sOrLkRakcuDx DtCSrMll//uEQQHeLjBJdRHws4UHogzlxJgUnS+yOKDpjlVgvPUs6XRx2w+0C9uwDd5f DWIXXCti1riP/3jFHj4W6y44KLLY+wEB8w+ZKV+sqpqjAyuA/aRMphIaFnhgrdIecqS+ ZSyQR5mEZ/bFO8njKF0TscjBmKbqbkziJWzLrDRAz3shtYZ6T799sIb86lcDWUnijADs HCOvTKUjazh5axuFWxCsrhseFoC6iekmd0q16V7LSlD0FGEgqfB7ZP5d93DcBVQ3MHnc Gr3A== X-Gm-Message-State: AOUpUlHDetEftpi3SDqqN8bF0dIOKyeHxFC7xxBgrDuNA5HGF15+B3S2 FXLIHV0Eo2omV1PKuw3njgn1hyF2n1YTlQ== X-Google-Smtp-Source: AA+uWPzM/Eb+beb25k3oWmvoiYUdQFWYDTS0DOkKU9iyMEKgOf1iCYhOnV515vxpXOoYMcLpNhh1zg== X-Received: by 2002:a19:c715:: with SMTP id x21-v6mr3629083lff.110.1534411857339; Thu, 16 Aug 2018 02:30:57 -0700 (PDT) Received: from wkz-wmo.labs.westermo.se (static-193-12-47-89.cust.tele2.se. [193.12.47.89]) by smtp.gmail.com with ESMTPSA id l78-v6sm4982854lfl.4.2018.08.16.02.30.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Aug 2018 02:30:56 -0700 (PDT) From: Tobias Waldekranz To: Tobias Waldekranz Cc: Andrew Lunn , Florian Fainelli , "David S. Miller" , Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org (open list), netdev@vger.kernel.org (open list:ETHERNET PHY LIBRARY) Subject: [PATCH] net: phy: add tracepoints Date: Thu, 16 Aug 2018 11:30:53 +0200 Message-Id: <20180816093056.2485-1-tobias@waldekranz.com> X-Mailer: git-send-email 2.17.1 Organization: Westermo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Two tracepoints for now: * `phy_interrupt` Pretty self-explanatory. * `phy_state_change` Whenever the PHY's state machine is run, trace the old and the new state. Signed-off-by: Tobias Waldekranz --- drivers/net/phy/phy.c | 4 +++ include/trace/events/phy.h | 68 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 72 insertions(+) create mode 100644 include/trace/events/phy.h diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 9aabfa1a455a..8d22926f3962 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -38,6 +38,9 @@ #include +#define CREATE_TRACE_POINTS +#include + #define PHY_STATE_STR(_state) \ case PHY_##_state: \ return __stringify(_state); \ @@ -1039,6 +1042,7 @@ void phy_state_machine(struct work_struct *work) if (err < 0) phy_error(phydev); + trace_phy_state_change(phydev, old_state); if (old_state != phydev->state) phydev_dbg(phydev, "PHY state change %s -> %s\n", phy_state_to_str(old_state), diff --git a/include/trace/events/phy.h b/include/trace/events/phy.h new file mode 100644 index 000000000000..7ba6c0dda47e --- /dev/null +++ b/include/trace/events/phy.h @@ -0,0 +1,68 @@ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM phy + +#if !defined(_TRACE_PHY_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_PHY_H + +#include + +TRACE_EVENT(phy_interrupt, + TP_PROTO(int irq, struct phy_device *phydev), + TP_ARGS(irq, phydev), + TP_STRUCT__entry( + __field(int, irq) + __field(int, addr) + __field(int, state) + __array(char, ifname, IFNAMSIZ) + ), + TP_fast_assign( + __entry->irq = irq; + __entry->addr = phydev->mdio.addr; + __entry->state = phydev->state; + if (phydev->attached_dev) + memcpy(__entry->ifname, + netdev_name(phydev->attached_dev), + IFNAMSIZ); + else + memset(__entry->ifname, 0, IFNAMSIZ); + ), + TP_printk("phy-%d-irq irq=%d ifname=%16s state=%d", + __entry->addr, + __entry->irq, + __entry->ifname, + __entry->state + ) + ); + +TRACE_EVENT(phy_state_change, + TP_PROTO(struct phy_device *phydev, enum phy_state old_state), + TP_ARGS(phydev, old_state), + TP_STRUCT__entry( + __field(int, addr) + __field(int, state) + __field(int, old_state) + __array(char, ifname, IFNAMSIZ) + ), + TP_fast_assign( + __entry->addr = phydev->mdio.addr; + __entry->state = phydev->state; + __entry->old_state = old_state; + if (phydev->attached_dev) + memcpy(__entry->ifname, + netdev_name(phydev->attached_dev), + IFNAMSIZ); + else + memset(__entry->ifname, 0, IFNAMSIZ); + ), + TP_printk("phy-%d-change ifname=%16s old_state=%d state=%d", + __entry->addr, + __entry->ifname, + __entry->old_state, + __entry->state + ) + ); + +#endif /* _TRACE_PHY_H */ + +/* This part must be outside protection */ +#include -- 2.17.1