From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7AFC4321D for ; Fri, 17 Aug 2018 15:10:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90C87208DB for ; Fri, 17 Aug 2018 15:10:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90C87208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727837AbeHQSNl (ORCPT ); Fri, 17 Aug 2018 14:13:41 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:39140 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727333AbeHQSNl (ORCPT ); Fri, 17 Aug 2018 14:13:41 -0400 Received: by mail-io0-f195.google.com with SMTP id l7-v6so7157336iok.6; Fri, 17 Aug 2018 08:09:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3biRfyuaT6BVcGM1qgIUvnqqAZk+YLcaGd7l0DmvAKk=; b=Cx8Wy5hI5ZmLzsqq//W15TPPXBBCcqb4jRbU9wsQC1LkL05/c2eU/xvNQfMplx9N/2 hHoTQRwvD776NWJooUiVv96tmbFyvxNAOhgG7xHnqQ11bBCRNwiG0QvBM3VWDbb0mZNq 9UXgYCL+rybjnHR0G+PFPMeGSU7L7qwH2tHdwhdkqsI9Fc2Y3kd2if05knvXI0135c/O LNpNc2O7jvJvuKIGywHYzGRehtq6nIAw+vwcbENjrStdrrBxtgJucMlCyzxM+lGgw2sW gE+p7SZBCZaBLKgKShEbnPU3W+GjWVflx2dWg0MVK4Ns7uUKio28i4qeZ+pddZL4krpw Madw== X-Gm-Message-State: AOUpUlHoZF3Nun7X2ol25M1TbbnxbUM9neHFxjD/Lol+WHy3Oa0xQYiu iiyHHS3exnOZ+fCqbhw+6w== X-Google-Smtp-Source: AA+uWPyQCX25BBMQQ9cxekPOITvo04ib50lOR+0AtstZ0/jXi9IkBS57WgTAkj2XIxSKzgOqefLbHg== X-Received: by 2002:a6b:ed11:: with SMTP id n17-v6mr5044090iog.132.1534518596658; Fri, 17 Aug 2018 08:09:56 -0700 (PDT) Received: from localhost ([24.51.61.72]) by smtp.gmail.com with ESMTPSA id w193-v6sm2076126ita.11.2018.08.17.08.09.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Aug 2018 08:09:56 -0700 (PDT) Date: Fri, 17 Aug 2018 09:09:55 -0600 From: Rob Herring To: Paul Cercueil Cc: Linus Walleij , Mark Rutland , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil Subject: Re: [PATCH 3/7] pinctrl: ingenic: Merge GPIO functionality Message-ID: <20180817150955.GC20845@rob-hp-laptop> References: <20180816163544.9072-1-paul@crapouillou.net> <20180816163544.9072-3-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180816163544.9072-3-paul@crapouillou.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, this email is from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below. On Thu, 16 Aug 2018 18:35:40 +0200, Paul Cercueil wrote: > Merge the code of the gpio-ingenic driver into the pinctrl-ingenic > driver. > > The reason behind this, is that the same hardware block handles both pin > config / muxing and GPIO. > > Signed-off-by: Paul Cercueil The preferred subject prefix is "dt-bindings: : ...". > --- > .../bindings/pinctrl/ingenic,pinctrl.txt | 38 ++- > drivers/pinctrl/Kconfig | 2 + > drivers/pinctrl/pinctrl-ingenic.c | 337 ++++++++++++++++++++- > 3 files changed, 365 insertions(+), 12 deletions(-) > DT bindings (including binding headers) should be a separate patch. See Documentation/devicetree/bindings/submitting-patches.txt.