From: Himanshu Jha <himanshujha199640@gmail.com>
To: zhong jiang <zhongjiang@huawei.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
nicolas.palix@imag.fr, michal.lkml@markovi.net,
yamada.masahiro@socionext.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Coccinelle: remove pci_alloc_consistent semantic to dectect in zalloc-simple.cocci
Date: Sat, 18 Aug 2018 20:22:43 +0530 [thread overview]
Message-ID: <20180818145243.GA2150@himanshu-Vostro-3559> (raw)
In-Reply-To: <5B7828D2.5010506@huawei.com>
On Sat, Aug 18, 2018 at 10:10:26PM +0800, zhong jiang wrote:
> On 2018/8/18 22:01, Julia Lawall wrote:
> >
> > On Sat, 18 Aug 2018, zhong jiang wrote:
> >
> >> On 2018/8/18 20:52, Himanshu Jha wrote:
> >>> On Sat, Aug 18, 2018 at 08:01:40PM +0800, zhong jiang wrote:
> >>>> Because pci_alloc_consistent has been deprecated. We prefer to use
> >>>> dam_alloc_coherent directly. Therefore, we should remove pci_alloc_consistent
> >>> ^^^ typo "dma"
> >>>
> >>> Also, typo in the patch subject "dectect" -> "detect"
> >> Thanks, will fix it in v2.
> >>> Otherwise,
> >>>
> >>> Acked-by: Himanshu Jha <himanshujha199640@gmail.com>
> >>>
> >>> Thanks for cleaning up, we still have few more *_alloc/memset
> >>> in the mainline, especially in the scsi subsystem, even after
> >>> I cleaned up with two long patch series in the past.
> >>>
> >> I post same patches like *_alloc/memset in the scsi subsystem. Unfortunately,
> >> Maintainer maybe do not care about the change. therefore, None of my patches
> >> are received and rarely feedback.
> > Maybe they will be picked up later.
> Hope so. It's been more than a month since I post the patches. Maybe I should give a kindly ping. :-)
Heh! The problem is Martin only when picks up patches if the driver
maintainer Acks them, and it happens very rarely until you have
a *real* bugfix.
But since these patches are simple, so Martin should pick it up
even if the patch doesn't receive any feedback.
If you ping, then certainly Martin will give you the same feedback.
Maybe you can make them happy by sending a syzbot bugfix ;)
--
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology
prev parent reply other threads:[~2018-08-18 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 12:01 zhong jiang
2018-08-18 12:19 ` Julia Lawall
2018-08-18 12:52 ` Himanshu Jha
2018-08-18 13:56 ` zhong jiang
2018-08-18 14:01 ` Julia Lawall
2018-08-18 14:10 ` zhong jiang
2018-08-18 14:52 ` Himanshu Jha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180818145243.GA2150@himanshu-Vostro-3559 \
--to=himanshujha199640@gmail.com \
--cc=Gilles.Muller@lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®