mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nishad Kamdar <nishadkamdar@gmail.com>
Cc: "Joe Perches" <joe@perches.com>, NeilBrown <neil@brown.name>,
	devel@driverdev.osuosl.org,
	"Christian Lütke-Stetzkamp" <christian@lkamp.de>,
	linux-kernel@vger.kernel.org, "John Crispin" <blogic@openwrt.org>
Subject: Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages
Date: Sun, 19 Aug 2018 13:34:01 +0200	[thread overview]
Message-ID: <20180819113401.GB18715@kroah.com> (raw)
In-Reply-To: <20180819100458.GA13296@nishad>

On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote:
> Fixed four debug macros and their usages. Replaced printk with
> dev_<level> without __func__ or __LINE__ or current->comm and
> current->pid. Further removed the do {} while(0) loop for single
> statement macros.
> Out of the four, replaced all usages of ERR_MSG and IRQ_MSG with
> dev_err() in the code itself and dropped them from dbg.h.
> Removed all INIT_MSG usages and dropped it from dgb.h.
> Issues found by checkpatch.

This needs to be multiple patches.  One for each type of macro you are
deleting/changing, not all lumped together into one big patch.

Plaese fix that up and resend.

thanks,

greg k-h

  reply	other threads:[~2018-08-19 11:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-19 10:05 Nishad Kamdar
2018-08-19 11:34 ` Greg Kroah-Hartman [this message]
2018-08-20 16:32   ` Nishad Kamdar
2018-08-20 17:59   ` Joe Perches
2018-08-20  9:22 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180819113401.GB18715@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=blogic@openwrt.org \
    --cc=christian@lkamp.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=nishadkamdar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®