mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Sedat Dilek <sedat.dilek@credativ.de>
Cc: kbuild-all@01.org, Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Sedat Dilek <sedat.dilek@credativ.de>,
	Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning
Date: Sun, 19 Aug 2018 23:23:50 +0800	[thread overview]
Message-ID: <201808192331.eoVFEPil%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180819135135.8801-1-sedat.dilek@credativ.de>

[-- Attachment #1: Type: text/plain, Size: 3433 bytes --]

Hi Sedat,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on wsa/i2c/for-next]
[also build test WARNING on v4.18 next-20180817]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sedat-Dilek/i2c-Remove-Wno-deprecated-declarations-compiler-warning/20180819-215230
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: i386-randconfig-a0-201833 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers//i2c/i2c-core-base.c: In function 'i2c_do_add_adapter':
>> drivers//i2c/i2c-core-base.c:1128:2: warning: 'attach_adapter' is deprecated (declared at include/linux/i2c.h:274) [-Wdeprecated-declarations]
     if (driver->attach_adapter) {
     ^
   drivers//i2c/i2c-core-base.c:1134:3: warning: 'attach_adapter' is deprecated (declared at include/linux/i2c.h:274) [-Wdeprecated-declarations]
      driver->attach_adapter(adap);
      ^

vim +/attach_adapter +1128 drivers//i2c/i2c-core-base.c

9c1600ed drivers/i2c/i2c-core.c David Brownell  2007-05-01  1120  
69b0089a drivers/i2c/i2c-core.c Jean Delvare    2009-12-06  1121  static int i2c_do_add_adapter(struct i2c_driver *driver,
69b0089a drivers/i2c/i2c-core.c Jean Delvare    2009-12-06  1122  			      struct i2c_adapter *adap)
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1123  {
4735c98f drivers/i2c/i2c-core.c Jean Delvare    2008-07-14  1124  	/* Detect supported devices on that bus, and instantiate them */
4735c98f drivers/i2c/i2c-core.c Jean Delvare    2008-07-14  1125  	i2c_detect(adap, driver);
4735c98f drivers/i2c/i2c-core.c Jean Delvare    2008-07-14  1126  
4735c98f drivers/i2c/i2c-core.c Jean Delvare    2008-07-14  1127  	/* Let legacy drivers scan this bus for matching devices */
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27 @1128  	if (driver->attach_adapter) {
a920ff41 drivers/i2c/i2c-core.c Jean Delvare    2011-04-17  1129  		dev_warn(&adap->dev, "%s: attach_adapter method is deprecated\n",
a920ff41 drivers/i2c/i2c-core.c Jean Delvare    2011-04-17  1130  			 driver->driver.name);
b93d3d37 drivers/i2c/i2c-core.c Andy Shevchenko 2016-08-25  1131  		dev_warn(&adap->dev,
b93d3d37 drivers/i2c/i2c-core.c Andy Shevchenko 2016-08-25  1132  			 "Please use another way to instantiate your i2c_client\n");
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1133  		/* We ignore the return code; if it fails, too bad */
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1134  		driver->attach_adapter(adap);
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1135  	}
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1136  	return 0;
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1137  }
026526f5 drivers/i2c/i2c-core.c Jean Delvare    2008-01-27  1138  

:::::: The code at line 1128 was first introduced by commit
:::::: 026526f5afcd421dce110f53e4c4e2b9e78753c2 i2c: Drop redundant i2c_driver.list

:::::: TO: Jean Delvare <khali@linux-fr.org>
:::::: CC: Jean Delvare <khali@hyperion.delvare>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27137 bytes --]

  reply	other threads:[~2018-08-19 15:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-19 13:51 Sedat Dilek
2018-08-19 15:23 ` kbuild test robot [this message]
2018-08-19 16:46 ` Linus Torvalds
2018-08-20  2:12   ` Benjamin Herrenschmidt
2018-08-20  8:06     ` Wolfram Sang
2018-08-20 11:25       ` Benjamin Herrenschmidt
2018-08-20 20:36       ` Linus Torvalds
2018-08-21  2:04         ` Wolfram Sang
2018-08-24 13:01 ` Wolfram Sang
2018-08-24 13:49   ` Sedat Dilek
2018-08-24 14:07     ` Wolfram Sang
2018-08-24 14:19       ` Sedat Dilek
2018-08-24 15:01         ` Wolfram Sang
2018-08-24 15:03           ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201808192331.eoVFEPil%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=sedat.dilek@credativ.de \
    --cc=torvalds@linux-foundation.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®