From: Tejun Heo <tj@kernel.org>
To: wang.yi59@zte.com.cn
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn
Subject: Re: [PATCH] workqueue: fix memory leak in wq_numa_init()
Date: Mon, 20 Aug 2018 09:00:36 -0700 [thread overview]
Message-ID: <20180820160036.GL3978217@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <201808201205500126227@zte.com.cn>
On Mon, Aug 20, 2018 at 12:05:50PM +0800, wang.yi59@zte.com.cn wrote:
> Gentle ping :)
>
> > The 'tbl' variable may leak when return in function
> > wq_numa_init(), and this patch fixes this.
> >
> > Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> > Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
It's a kernel bug path where we might as well crash. Whether the tbl
gets leaked or not doesn't matter.
Thanks.
--
tejun
prev parent reply other threads:[~2018-08-20 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 1:20 Yi Wang
[not found] ` <201808201205500126227@zte.com.cn>
2018-08-20 16:00 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820160036.GL3978217@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=jiang.biao2@zte.com.cn \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wang.yi59@zte.com.cn \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome