From: Bjorn Helgaas <helgaas@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: David Miller <davem@davemloft.net>,
jian-hong@endlessm.com, nic_swsd@realtek.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@endlessm.com, linux-pci@vger.kernel.org,
Marc Zyngier <marc.zyngier@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] r8169: don't use MSI-X on RTL8106e
Date: Mon, 20 Aug 2018 13:44:38 -0500 [thread overview]
Message-ID: <20180820184438.GA154536@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <ac30d4e6-6411-09e6-1205-96e3e8e29f6f@gmail.com>
[+cc Marc, Thomas, Christoph, linux-pci)
(beginning of thread at [1])
On Thu, Aug 16, 2018 at 09:50:48PM +0200, Heiner Kallweit wrote:
> On 16.08.2018 21:39, David Miller wrote:
> > From: Heiner Kallweit <hkallweit1@gmail.com>
> > Date: Thu, 16 Aug 2018 21:37:31 +0200
> >
> >> On 16.08.2018 21:21, David Miller wrote:
> >>> From: <jian-hong@endlessm.com>
> >>> Date: Wed, 15 Aug 2018 14:21:10 +0800
> >>>
> >>>> Found the ethernet network on ASUS X441UAR doesn't come back on resume
> >>>> from suspend when using MSI-X. The chip is RTL8106e - version 39.
> >>>
> >>> Heiner, please take a look at this.
> >>>
> >>> You recently disabled MSI-X on RTL8168g for similar reasons.
> >>>
> >>> Now that we've seen two chips like this, maybe there is some other
> >>> problem afoot.
> >>>
> >> Thanks for the hint. I saw it already and just contacted Realtek
> >> whether they are aware of any MSI-X issues with particular chip
> >> versions. With the chip versions I have access to MSI-X works fine.
> >>
> >> There's also the theoretical option that the issues are caused by
> >> broken BIOS's. But so far only chip versions have been reported
> >> which are very similar, at least with regard to version number
> >> (2x VER_40, 1x VER_39). So they may share some buggy component.
> >>
> >> Let's see whether Realtek can provide some hint.
> >> If more chip versions are reported having problems with MSI-X,
> >> then we could switch to a whitelist or disable MSI-X in general.
> >
> > It could be that we need to reprogram some register(s) on resume,
> > which normally might not be needed, and that is what is causing the
> > problem with some chips.
> >
> Indeed. That's what I'm checking with Realtek.
> In the register list in the r8169 driver there's one entry which
> seems to indicate that there are MSI-X specific settings.
> However this register isn't used, and the r8168 vendor driver
> uses only MSI. And there are no public datasheets.
Do we have any information about these chip versions in other systems?
Or other devices using MSI-X in the same ASUS system? It seems
possible that there's some PCI core or suspend/resume issue with MSI-X
and this patch just avoids it without fixing the root cause.
It might be useful to have a kernel.org bugzilla with the complete
dmesg, "sudo lspci -vv" output, and /proc/interrupts contents archived
for future reference.
[1] https://lkml.kernel.org/r/20180815062110.16155-1-jian-hong@endlessm.com
next prev parent reply other threads:[~2018-08-20 18:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 6:21 jian-hong
2018-08-16 19:21 ` David Miller
2018-08-16 19:37 ` Heiner Kallweit
2018-08-16 19:39 ` David Miller
2018-08-16 19:50 ` Heiner Kallweit
2018-08-20 18:44 ` Bjorn Helgaas [this message]
2018-08-20 20:46 ` Heiner Kallweit
2018-08-21 19:31 ` David Miller
2018-08-21 20:48 ` Heiner Kallweit
2018-08-22 11:44 ` Thomas Gleixner
2018-08-22 19:49 ` Heiner Kallweit
2018-08-23 10:46 ` Jian-Hong Pan
2018-08-23 13:38 ` Bjorn Helgaas
2018-08-27 10:46 ` Jian-Hong Pan
2018-08-21 8:28 ` Marc Zyngier
2018-08-21 20:54 ` Heiner Kallweit
2018-08-20 20:40 ` Florian Fainelli
2018-08-20 20:56 ` Heiner Kallweit
2018-08-17 5:07 ` [PATCH v2 net] " Jian-Hong Pan
2018-08-19 18:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820184438.GA154536@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=hkallweit1@gmail.com \
--cc=jian-hong@endlessm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=marc.zyngier@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®