From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10264C4321D for ; Wed, 22 Aug 2018 01:40:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8B7C217B4 for ; Wed, 22 Aug 2018 01:40:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8B7C217B4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ah.jp.nec.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727552AbeHVFCt convert rfc822-to-8bit (ORCPT ); Wed, 22 Aug 2018 01:02:49 -0400 Received: from tyo162.gate.nec.co.jp ([114.179.232.162]:51306 "EHLO tyo162.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726357AbeHVFCt (ORCPT ); Wed, 22 Aug 2018 01:02:49 -0400 Received: from mailgate01.nec.co.jp ([114.179.233.122]) by tyo162.gate.nec.co.jp (8.15.1/8.15.1) with ESMTPS id w7M1dxko006758 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 22 Aug 2018 10:39:59 +0900 Received: from mailsv02.nec.co.jp (mailgate-v.nec.co.jp [10.204.236.94]) by mailgate01.nec.co.jp (8.15.1/8.15.1) with ESMTP id w7M1dx8I026088; Wed, 22 Aug 2018 10:39:59 +0900 Received: from mail03.kamome.nec.co.jp (mail03.kamome.nec.co.jp [10.25.43.7]) by mailsv02.nec.co.jp (8.15.1/8.15.1) with ESMTP id w7M1bci4002501; Wed, 22 Aug 2018 10:39:59 +0900 Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.150] [10.38.151.150]) by mail03.kamome.nec.co.jp with ESMTP id BT-MMP-2975987; Wed, 22 Aug 2018 10:37:50 +0900 Received: from BPXM23GP.gisp.nec.co.jp ([10.38.151.215]) by BPXC22GP.gisp.nec.co.jp ([10.38.151.150]) with mapi id 14.03.0319.002; Wed, 22 Aug 2018 10:37:49 +0900 From: Naoya Horiguchi To: Andrew Morton CC: "linux-mm@kvack.org" , Michal Hocko , "xishi.qiuxishi@alibaba-inc.com" , "zy.zhengyi@alibaba-inc.com" , "linux-kernel@vger.kernel.org" , Mike Kravetz Subject: Re: [PATCH v2 0/2] mm: soft-offline: fix race against page allocation Thread-Topic: [PATCH v2 0/2] mm: soft-offline: fix race against page allocation Thread-Index: AQHUNOlnrqT+pxWFwUe9BDyggy7ShKTKcMQA Date: Wed, 22 Aug 2018 01:37:48 +0000 Message-ID: <20180822013748.GA10343@hori1.linux.bs1.fc.nec.co.jp> References: <1531805552-19547-1-git-send-email-n-horiguchi@ah.jp.nec.com> <20180815154334.f3eecd1029a153421631413a@linux-foundation.org> In-Reply-To: <20180815154334.f3eecd1029a153421631413a@linux-foundation.org> Accept-Language: en-US, ja-JP Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.51.8.80] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 15, 2018 at 03:43:34PM -0700, Andrew Morton wrote: > On Tue, 17 Jul 2018 14:32:30 +0900 Naoya Horiguchi wrote: > > > I've updated the patchset based on feedbacks: > > > > - updated comments (from Andrew), > > - moved calling set_hwpoison_free_buddy_page() from mm/migrate.c to mm/memory-failure.c, > > which is necessary to check the return code of set_hwpoison_free_buddy_page(), > > - lkp bot reported a build error when only 1/2 is applied. > > > > > mm/memory-failure.c: In function 'soft_offline_huge_page': > > > >> mm/memory-failure.c:1610:8: error: implicit declaration of function > > > 'set_hwpoison_free_buddy_page'; did you mean 'is_free_buddy_page'? > > > [-Werror=implicit-function-declaration] > > > if (set_hwpoison_free_buddy_page(page)) > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > is_free_buddy_page > > > cc1: some warnings being treated as errors > > > > set_hwpoison_free_buddy_page() is defined in 2/2, so we can't use it > > in 1/2. Simply doing s/set_hwpoison_free_buddy_page/!TestSetPageHWPoison/ > > will fix this. > > > > v1: https://lkml.org/lkml/2018/7/12/968 > > > > Quite a bit of discussion on these two, but no actual acks or > review-by's? Really sorry for late response. Xishi provided feedback on previous version, but no final ack/reviewed-by. This fix should work on the reported issue, but rewriting soft-offlining without PageHWPoison flag would be the better fix (no actual patch yet.) I'm not sure this patch should go to mainline immediately. Thanks, Naoya Horiguchi