From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7298DC4321D for ; Wed, 22 Aug 2018 10:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 262782075A for ; Wed, 22 Aug 2018 10:49:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=verge.net.au header.i=@verge.net.au header.b="k83G3tRE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 262782075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=verge.net.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728655AbeHVONX (ORCPT ); Wed, 22 Aug 2018 10:13:23 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:50371 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726983AbeHVONX (ORCPT ); Wed, 22 Aug 2018 10:13:23 -0400 Received: from reginn.horms.nl (watermunt.horms.nl [80.127.179.77]) by kirsty.vergenet.net (Postfix) with ESMTPA id 911E125AD64; Wed, 22 Aug 2018 20:48:58 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1534934938; bh=ug7UspIbdt69vYxJv7dHtPnqvWdViGsrQZyLBPfJWkQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k83G3tREY/5DreqKDZRl1pr8r8G7WfPNYZdllWaZV1XAlVJ/M3eGYI2BVTfLgAIBQ I6r+cdH4gZ9f2ekqY3/oWR2/PnTOXwhSgEzlI07hXed69kySHFUGVi8eveSm/QSw1I 20bhKOlT+IwLPyYmRJmPm81XL2LD7VJki9cVdmHU= Received: by reginn.horms.nl (Postfix, from userid 7100) id 7379B94040B; Wed, 22 Aug 2018 12:48:56 +0200 (CEST) Date: Wed, 22 Aug 2018 12:48:56 +0200 From: Simon Horman To: Fabrizio Castro Cc: Wolfgang Grandegger , Marc Kleine-Budde , Rob Herring , Mark Rutland , "David S. Miller" , linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Geert Uytterhoeven , Chris Paterson , Biju Das , linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support Message-ID: <20180822104856.34nusjd4ajtwb4ef@verge.net.au> References: <1534516703-11448-1-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1534516703-11448-1-git-send-email-fabrizio.castro@bp.renesas.com> Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 17, 2018 at 03:38:23PM +0100, Fabrizio Castro wrote: > Document RZ/G2M (r8a774a1) SoC bindings. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das Reviewed-by: Simon Horman > --- > This patch applies on top of next-20180817 > > Documentation/devicetree/bindings/net/can/rcar_can.txt | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt > index 94a7f33..84afc78 100644 > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt > @@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings > Required properties: > - compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743 SoC. > "renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC. > + "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC. > "renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC. > "renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC. > "renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC. > @@ -16,7 +17,8 @@ Required properties: > "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device. > "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1 > compatible device. > - "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device. > + "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2 > + compatible device. > When compatible with the generic version, nodes must list the > SoC-specific version corresponding to the platform first > followed by the generic version. > @@ -24,7 +26,9 @@ Required properties: > - reg: physical base address and size of the R-Car CAN register map. > - interrupts: interrupt specifier for the sole interrupt. > - clocks: phandles and clock specifiers for 3 CAN clock inputs. > -- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk". > +- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk", and Minor comment: Personally I would start a new sentence at "and". Question: Is a driver update required so support 2-clock SoCs? > + 3 clock input name strings for every other SoC: "clkp1", "clkp2", > + "can_clk". > - pinctrl-0: pin control group to be used for this controller. > - pinctrl-names: must be "default". > > -- > 2.7.4 >