From: Christian Brauner <christian@brauner.io>
To: serge@hallyn.com, jmorris@namei.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Christian Brauner <christian@brauner.io>
Subject: [PATCH v1] security/capabilities: remove check for -EINVAL
Date: Wed, 22 Aug 2018 13:52:40 +0200 [thread overview]
Message-ID: <20180822115240.18196-1-christian@brauner.io> (raw)
bprm_caps_from_vfs_caps() never returned -EINVAL so remove the
rc == -EINVAL check.
Signed-off-by: Christian Brauner <christian@brauner.io>
---
v0 -> v1
- non-functional changes:
adapt commit message to reflect the fact that
bprm_caps_from_vfs_caps() never actuall returned -EINVAL.
---
security/commoncap.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/security/commoncap.c b/security/commoncap.c
index f4c33abd9959..6012f0cd8157 100644
--- a/security/commoncap.c
+++ b/security/commoncap.c
@@ -684,9 +684,6 @@ static int get_file_caps(struct linux_binprm *bprm, bool *effective, bool *has_f
}
rc = bprm_caps_from_vfs_caps(&vcaps, bprm, effective, has_fcap);
- if (rc == -EINVAL)
- printk(KERN_NOTICE "%s: cap_from_disk returned %d for %s\n",
- __func__, rc, bprm->filename);
out:
if (rc)
--
2.17.1
next reply other threads:[~2018-08-22 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 11:52 Christian Brauner [this message]
2018-08-22 13:58 ` Serge E. Hallyn
2018-08-23 16:48 ` James Morris
2018-08-29 16:09 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822115240.18196-1-christian@brauner.io \
--to=christian@brauner.io \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®