From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32F2C433F5 for ; Fri, 24 Aug 2018 21:50:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 875FD208B2 for ; Fri, 24 Aug 2018 21:50:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 875FD208B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727513AbeHYB0q (ORCPT ); Fri, 24 Aug 2018 21:26:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:37406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726770AbeHYB0q (ORCPT ); Fri, 24 Aug 2018 21:26:46 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 017D0208B2; Fri, 24 Aug 2018 21:50:18 +0000 (UTC) Date: Fri, 24 Aug 2018 17:50:17 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Shuah Khan , Ingo Molnar , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/32] selftests/ftrace: Fix checkbashisms errors Message-ID: <20180824175017.7a902933@gandalf.local.home> In-Reply-To: <153443723502.23257.14228272091408974348.stgit@devbox> References: <153443695002.23257.13628220023468200991.stgit@devbox> <153443723502.23257.14228272091408974348.stgit@devbox> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Aug 2018 01:33:55 +0900 Masami Hiramatsu wrote: > Fix a test case to make checkbashisms clean. > > Signed-off-by: Masami Hiramatsu > --- > .../trigger/trigger-trace-marker-snapshot.tc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-snapshot.tc b/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-snapshot.tc > index 79ce7d51350b..df246e505af7 100644 > --- a/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-snapshot.tc > +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-snapshot.tc > @@ -39,10 +39,10 @@ test_trace() { > fi > echo "testing $line for >$x<" > match=`echo $line | sed -e "s/>$x - if [ "$line" == "$match" ]; then > + if [ "$line" = "$match" ]; then > fail "$line does not have >$x< in it" > fi > - let x=$x+2 > + x=$((x+2)) I didn't realize "let" was a bashism. I've been using that on other shells I believe. But whatever. Acked-by: Steven Rostedt (VMware) -- Steve > done > } >