From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0EEBC433F5 for ; Fri, 24 Aug 2018 22:53:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 747BD20A8B for ; Fri, 24 Aug 2018 22:53:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 747BD20A8B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727464AbeHYCaW (ORCPT ); Fri, 24 Aug 2018 22:30:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:55786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726754AbeHYCaW (ORCPT ); Fri, 24 Aug 2018 22:30:22 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C5DB02098B; Fri, 24 Aug 2018 22:53:43 +0000 (UTC) Date: Fri, 24 Aug 2018 18:53:42 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Shuah Khan , Ingo Molnar , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 19/32] selftests/ftrace: Add a testcase for nop tracer Message-ID: <20180824185342.542d8a6a@gandalf.local.home> In-Reply-To: <153443748943.23257.13855745627496095446.stgit@devbox> References: <153443695002.23257.13628220023468200991.stgit@devbox> <153443748943.23257.13855745627496095446.stgit@devbox> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Aug 2018 01:38:09 +0900 Masami Hiramatsu wrote: > Add a testcase for nop tracer. This tracer has 2 test > options, so check it too. > I'd rather not include this. In fact, I'd love to get rid of the nop options. They were added to make sure options worked when we first added them. They are actually pointless. The only point of this test is to know if options work or not. Hmm, I guess that is something that could possibly be valuable :-/ -- Steve > Signed-off-by: Masami Hiramatsu > --- > .../testing/selftests/ftrace/test.d/tracer/nop.tc | 22 ++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 tools/testing/selftests/ftrace/test.d/tracer/nop.tc > > diff --git a/tools/testing/selftests/ftrace/test.d/tracer/nop.tc b/tools/testing/selftests/ftrace/test.d/tracer/nop.tc > new file mode 100644 > index 000000000000..ca63e316e0f5 > --- /dev/null > +++ b/tools/testing/selftests/ftrace/test.d/tracer/nop.tc > @@ -0,0 +1,22 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > +# description: Test nop tracer > + > +# nop must be supported always > +grep -q "nop" available_tracers > + > +echo "nop" > current_tracer > + > +# nop provides 2 test options > +grep -q "test_nop_accept" trace_options > +grep -q "test_nop_refuse" trace_options > + > +# nop_accept always success > +echo "test_nop_accept" > trace_options > +echo "notest_nop_accept" > trace_options > + > +# nop_refuse always failed > +! echo "test_nop_refuse" > trace_options > +! echo "notest_nop_refuse" > trace_options > + > +exit 0