From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sven Luthi <dev@svenluthi.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: drivers: adl_pci9118: Fixes format of line 1283.
Date: Sat, 25 Aug 2018 10:14:50 +0300 [thread overview]
Message-ID: <20180825071450.pwque6fw6vvy3sl7@mwanda> (raw)
In-Reply-To: <20180824210657.16926-1-dev@svenluthi.com>
On Fri, Aug 24, 2018 at 11:06:56PM +0200, Sven Luthi wrote:
> Checkpatch repored "Lines should not end with a '('" for line 1283.
>
> Moved opening parenthesis of function on line 1283 onto next line.
>
> Signed-off-by: Sven Luthi <dev@svenluthi.com>
> ---
> drivers/staging/comedi/drivers/adl_pci9118.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
> index 2528ca0ede6d..07431dc9cde9 100644
> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
> @@ -1280,8 +1280,8 @@ static int pci9118_ai_cmdtest(struct comedi_device *dev,
> } else {
> arg = cmd->convert_arg * cmd->chanlist_len;
> }
> - err |= comedi_check_trigger_arg_min(
> - &cmd->scan_begin_arg, arg);
> + err |= comedi_check_trigger_arg_min
> + (&cmd->scan_begin_arg, arg);
The original is fine. It's probably better than the new version.
Checkpatch.pl is just a hint, not a command.
regards,
dan carpenter
prev parent reply other threads:[~2018-08-25 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 21:06 Sven Luthi
2018-08-24 21:06 ` [PATCH] staging: comedi: drivers: dt3000: Fixes warning on multiline dereference Sven Luthi
2018-08-25 7:14 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180825071450.pwque6fw6vvy3sl7@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=dev@svenluthi.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®