From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E222C433F4 for ; Sat, 25 Aug 2018 15:44:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0EE0221763 for ; Sat, 25 Aug 2018 15:44:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=bidouilliste.com header.i=@bidouilliste.com header.b="mxTLWjV4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EE0221763 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bidouilliste.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726987AbeHYTXS (ORCPT ); Sat, 25 Aug 2018 15:23:18 -0400 Received: from mail.blih.net ([212.83.177.182]:28504 "EHLO mail.blih.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726714AbeHYTXS (ORCPT ); Sat, 25 Aug 2018 15:23:18 -0400 Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 79afe6f8; Sat, 25 Aug 2018 17:43:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=u9nVa1JLVVhjUsDQu4LYrvL934s=; b=mxTLWjV41TtVSHTSTEvWCpLhxDiz 3BicREZZqz53Wc6XDvobdSIlrdBKVEnD7NK6gGg1izRMIbXQY9uvOPBZFUmNPslP RUSVTTSuHE4HR39yU8Wf9SYjX0S34J3bcH5YzccVsfWCzkvPjZKnaY17Gzevhc5X 5RrK2F3K1/F1pEw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=cxfPduTMaipGjjxG8PlzQVNIhDmFt7dwNBTcNQZ4ZjXkBYhbbmD/IqL0 XxbcmS3PUPXGbNWII0ntaIcBSc2O/l2kM03TZVDq7saO0TAa3lw/EVwMst3ohoiE oOpQXNFD8LI4bV0f0nyXdwFlW43UUM3+bkN2aHW3BRzXdcjWF80= Received: from knuckles.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 2f976c4c TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Sat, 25 Aug 2018 17:43:53 +0200 (CEST) Date: Sat, 25 Aug 2018 17:43:52 +0200 From: Emmanuel Vadot To: Eduardo Valentin Cc: Mark Rutland , devicetree@vger.kernel.org, "open list:THERMAL" , Maxime Ripard , Catalin Marinas , Will Deacon , "linux-kernel@vger.kernel.org" , Emmanuel Vadot , Chen-Yu Tsai , Rob Herring , Zhang Rui , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH 1/7] dt-bindings: Add DT bindings documentation for Allwinner Thermal Sensor Controller Message-Id: <20180825174352.68de8a2720f4c91b987be914@bidouilliste.com> In-Reply-To: <20180824230338.GA19399@localhost.localdomain> References: <20180804070355.14857-1-manu@freebsd.org> <20180820111755.rzg7l2lznmbpuf2e@flea> <20180820140737.xmqhu5ndqzehvkql@flea> <20180820162715.49e6d8a469ece983f3c1d288@bidouilliste.com> <20180824145840.isdcg3fr6mw4ntzg@flea> <20180824215921.59d060b54eb3a1e7d1552bde@bidouilliste.com> <20180824230338.GA19399@localhost.localdomain> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, 24 Aug 2018 16:03:40 -0700 Eduardo Valentin wrote: > On Fri, Aug 24, 2018 at 09:59:21PM +0200, Emmanuel Vadot wrote: > > > > Hi, > > > > On Fri, 24 Aug 2018 16:58:40 +0200 > > Maxime Ripard wrote: > > > > > Hi, > > > > > > On Mon, Aug 20, 2018 at 04:27:15PM +0200, Emmanuel Vadot wrote: > > > > On Mon, 20 Aug 2018 16:07:37 +0200 > > > > Maxime Ripard wrote: > > > > > > > > > On Mon, Aug 20, 2018 at 07:41:22AM -0600, Rob Herring wrote: > > > > > > On Mon, Aug 20, 2018 at 5:17 AM Maxime Ripard wrote: > > > > > > > > > > > > > > On Sat, Aug 04, 2018 at 09:03:49AM +0200, Emmanuel Vadot wrote: > > > > > > > > This patch adds documentation for Device-Tree bindings for the Allwinner > > > > > > > > Thermal Sensor Controller found on the H3, H5 and A64 SoCs > > > > > > > > > > > > > > > > Signed-off-by: Emmanuel Vadot > > > > > > > > > > > > > > I'm not going to merge a binding for a device that doesn't have any > > > > > > > driver implemented at the moment in Linux. > > > > > > > > > > > > I'll take it then. Linux is not the only DT client. > > > > > > > > > > Then don't complain if we ever have to break the ABI. We never tested > > > > > that hardware, never had any code running on it, and it *will* cause > > > > > some issues. For example, the calibration data have never been used > > > > > and how they should be represented have never been described, since no > > > > > one ever actually tried to use it. > > > > > > > > > > And sure, Linux is not the only DT client. Just like FreeBSD isn't. > > > > > > > > What kind of data would you need for me to make things better ? > > > > We have the driver in FreeBSD for almost two years now, whne I started > > > > to see how to upstream it I noticed a lot of problems and spent 4 or 5 > > > > days to try on all the SoCs mentionned in the serie, the only SoC I > > > > didn't include it the A83T as for some reason I couldn't make the > > > > driver work. > > > > > > Do you have a link to that driver? > > > > https://github.com/freebsd/freebsd/blob/master/sys/arm/allwinner/aw_thermal.c > > > > > How and how much did you test it? > > > > Using a cheap IR thermometer as it's all I can afford. > > Then running multiples cpufreq-a53 process and comparing the result. > > Did the same without using the calibration data, result where closer > > when I used them. > > > > > Are you using the calibration data stored in the SID? > > > > Yes, which is why the serie contain the nvmem cell for the SID. > > > > > > > > > I just hope that you understand that we cannot wait for Linux to > > > > have a driver to have some bindings. > > > > > > Just like I'm sure you can understand that just merging the DT bits > > > without testing anything caused some troubles in the past, and I don't > > > want to discover it in a year from now. > > > > I do, I don't like wrong DT info as much as you do I think. I had > > the unfortunate event to find that the sun4i-a10-timer compatible used > > in every soc is plain wrong for !A10 and !A13, patches comming soon. > > I want those bits merged but I also want that they reflect reality, > > this is not a hard driver to do, NetBSD also have one I think, maybe > > OpenBSD do to. > > > I would prefer to see a series of DT bindings + driver. Can you send > your next iteration with the driver so we can review both together? You mean a link to the FreeBSD driver (and OpenBSD since they have one too) in the cover letter ? > > > > > Maxime > > > > > > -- > > > Maxime Ripard, Bootlin > > > Embedded Linux and Kernel engineering > > > https://bootlin.com > > > > > > -- > > Emmanuel Vadot > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Emmanuel Vadot