mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	x86@kernel.org, Michal Marek <michal.lkml@markovi.net>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] objtool: remove workaround for unreachable warnings from old GCC
Date: Mon, 27 Aug 2018 14:11:23 -0500	[thread overview]
Message-ID: <20180827191123.meeqzru5y2kwnd47@treble> (raw)
In-Reply-To: <1535341183-19994-1-git-send-email-yamada.masahiro@socionext.com>

On Mon, Aug 27, 2018 at 12:39:43PM +0900, Masahiro Yamada wrote:
> Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
> bumped the minimum GCC version to 4.6 for all architectures.
> 
> This effectively reverts commit da541b20021c ("objtool: Skip
> unreachable warnings for GCC 4.4 and older"), which was a workaround
> for GCC 4.4 or older.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

> ---
> 
>  scripts/Makefile.build | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 1c48572..5a2d1c9 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -246,8 +246,6 @@ objtool_args += --no-fp
>  endif
>  ifdef CONFIG_GCOV_KERNEL
>  objtool_args += --no-unreachable
> -else
> -objtool_args += $(call cc-ifversion, -lt, 0405, --no-unreachable)
>  endif
>  ifdef CONFIG_RETPOLINE
>  ifneq ($(RETPOLINE_CFLAGS),)
> -- 
> 2.7.4
> 

-- 
Josh

  reply	other threads:[~2018-08-27 19:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27  3:39 Masahiro Yamada
2018-08-27 19:11 ` Josh Poimboeuf [this message]
2018-08-30 11:02 ` [tip:core/urgent] objtool: Remove " tip-bot for Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180827191123.meeqzru5y2kwnd47@treble \
    --to=jpoimboe@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®