mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: tglx@linutronix.de
Cc: y2038@lists.linaro.org, linux-api@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	deepa.kernel@gmail.com, linux-arch@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 09/14] y2038: Change sys_utimensat() to use __kernel_timespec
Date: Mon, 27 Aug 2018 21:45:26 +0200	[thread overview]
Message-ID: <20180827194531.3796559-10-arnd@arndb.de> (raw)
In-Reply-To: <20180827194531.3796559-1-arnd@arndb.de>

When 32-bit architectures get changed to support 64-bit time_t,
utimensat() needs to use the new __kernel_timespec structure as its
argument.

The older utime(), utimes() and futimesat() system calls don't need a
corresponding change as they are no longer used on C libraries that have
64-bit time support.

As we do for the other syscalls that have timespec arguments, we reuse
the 'compat' syscall entry points to implement the traditional four
interfaces, and only leave the new utimensat() as a native handler,
so that the same code gets used on both 32-bit and 64-bit kernels
on each syscall.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 fs/utimes.c              | 2 +-
 include/linux/syscalls.h | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/utimes.c b/fs/utimes.c
index 79a65c163f40..d30f409ecc1a 100644
--- a/fs/utimes.c
+++ b/fs/utimes.c
@@ -166,7 +166,7 @@ long do_utimes(int dfd, const char __user *filename, struct timespec64 *times,
 }
 
 SYSCALL_DEFINE4(utimensat, int, dfd, const char __user *, filename,
-		struct timespec __user *, utimes, int, flags)
+		struct __kernel_timespec __user *, utimes, int, flags)
 {
 	struct timespec64 tstimes[2];
 
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index b3e27e5ee322..420ac881a610 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -513,7 +513,8 @@ asmlinkage long sys_timerfd_gettime(int ufd, struct __kernel_itimerspec __user *
 
 /* fs/utimes.c */
 asmlinkage long sys_utimensat(int dfd, const char __user *filename,
-				struct timespec __user *utimes, int flags);
+				struct __kernel_timespec __user *utimes,
+				int flags);
 
 /* kernel/acct.c */
 asmlinkage long sys_acct(const char __user *name);
-- 
2.18.0


  parent reply	other threads:[~2018-08-27 19:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 19:45 [PATCH 00/14] y2038 syscall changes for 4.20 Arnd Bergmann
2018-08-27 19:45 ` [PATCH 01/14] y2038: Remove unused time interfaces Arnd Bergmann
2018-08-27 19:45 ` [PATCH 02/14] y2038: Make do_gettimeofday() and get_seconds() inline Arnd Bergmann
2018-08-27 19:45 ` [PATCH 03/14] y2038: Globally rename compat_time to old_time32 Arnd Bergmann
2018-08-29 12:50   ` kbuild test robot
2018-08-29 12:50   ` [RFC PATCH] y2038: __get_old_timespec32() can be static kbuild test robot
2018-08-29 13:17     ` [Y2038] " Arnd Bergmann
2018-08-27 19:45 ` [PATCH 04/14] y2038: Remove newstat family from default syscall set Arnd Bergmann
2018-08-27 19:45 ` [PATCH 05/14] y2038: Remove stat64 " Arnd Bergmann
2018-08-27 19:45 ` [PATCH 06/14] asm-generic: Move common compat types to asm-generic/compat.h Arnd Bergmann
2018-08-27 19:45 ` [PATCH 07/14] asm-generic: Remove unneeded __ARCH_WANT_SYS_LLSEEK macro Arnd Bergmann
2018-08-27 19:45 ` [PATCH 08/14] asm-generic: Remove empty asm/unistd.h Arnd Bergmann
2018-08-27 19:45 ` Arnd Bergmann [this message]
2018-08-27 19:45 ` [PATCH 10/14] y2038: Compile utimes()/futimesat() conditionally Arnd Bergmann
2018-08-27 19:45 ` [PATCH 11/14] y2038: utimes: Rework #ifdef guards for compat syscalls Arnd Bergmann
2018-08-27 19:45 ` [PATCH 12/14] y2038: sched: Change sched_rr_get_interval to use __kernel_timespec Arnd Bergmann
2018-08-27 19:45 ` [PATCH 13/14] y2038: socket: Change recvmmsg " Arnd Bergmann
2018-08-27 19:45 ` [PATCH 14/14] y2038: signal: Change rt_sigtimedwait " Arnd Bergmann
2018-08-29 13:59 ` [PATCH 00/14] y2038 syscall changes for 4.20 Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180827194531.3796559-10-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=deepa.kernel@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®