From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240C9C433F5 for ; Tue, 28 Aug 2018 07:24:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF43A208B8 for ; Tue, 28 Aug 2018 07:24:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF43A208B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727251AbeH1LOV (ORCPT ); Tue, 28 Aug 2018 07:14:21 -0400 Received: from mga05.intel.com ([192.55.52.43]:1039 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726781AbeH1LOV (ORCPT ); Tue, 28 Aug 2018 07:14:21 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2018 00:24:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,298,1531810800"; d="scan'208";a="228220159" Received: from jsakkine-mobl1.fi.intel.com (HELO localhost) ([10.237.66.39]) by orsmga004.jf.intel.com with ESMTP; 28 Aug 2018 00:23:56 -0700 Date: Tue, 28 Aug 2018 10:23:55 +0300 From: Jarkko Sakkinen To: Dave Hansen Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, linux-sgx@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Peter Zijlstra , Borislav Petkov , Greg Kroah-Hartman , David Woodhouse , Alexei Starovoitov , Andi Kleen , Konrad Rzeszutek Wilk , Ricardo Neri , "Kirill A. Shutemov" , Andy Lutomirski , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)" Subject: Re: [PATCH v13 03/13] x86/cpufeatures: Add Intel-defined SGX leaf CPUID_12_EAX Message-ID: <20180828072355.GB15508@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-4-jarkko.sakkinen@linux.intel.com> <70dec13f-2182-e4d6-da71-a568d6e9354b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70dec13f-2182-e4d6-da71-a568d6e9354b@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 27, 2018 at 12:39:36PM -0700, Dave Hansen wrote: > On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote: > > + /* Intel SGX features: level 0x00000012 */ > > + if (c->cpuid_level >= 0x00000012) { > > + cpuid(0x00000012, &eax, &ebx, &ecx, &edx); > > + > > + c->x86_capability[CPUID_12_EAX] = eax; > > + } > > I've given this specific bit of feedback at least once in the past. > These patches are not ordered properly. You introduce this in the next > patch: > > +#define SGX_CPUID 0x12 Yeah, my mistake probably when squashing fixups. /Jarkko