From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B54DDC433F5 for ; Tue, 28 Aug 2018 12:43:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64E802088E for ; Tue, 28 Aug 2018 12:43:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64E802088E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727744AbeH1QfL (ORCPT ); Tue, 28 Aug 2018 12:35:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37480 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbeH1QfL (ORCPT ); Tue, 28 Aug 2018 12:35:11 -0400 Received: from localhost (unknown [104.153.224.167]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 74527CDD; Tue, 28 Aug 2018 12:43:39 +0000 (UTC) Date: Tue, 28 Aug 2018 14:43:29 +0200 From: Greg Kroah-Hartman To: Juergen Gross Cc: Nick Desaulniers , tglx@linutronix.de, mingo@redhat.com, stable@vger.kernel.org, "H. Peter Anvin" , x86@kernel.org, Boris Ostrovsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/irqflags: mark native_restore_fl extern inline Message-ID: <20180828124329.GB14243@kroah.com> References: <20180827214011.55428-1-ndesaulniers@google.com> <20180828051300.GB2107@kroah.com> <5c949906-ae9d-2848-d5d0-f402aed4b9f3@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c949906-ae9d-2848-d5d0-f402aed4b9f3@suse.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 28, 2018 at 08:02:37AM +0200, Juergen Gross wrote: > On 28/08/18 07:13, Greg Kroah-Hartman wrote: > > On Mon, Aug 27, 2018 at 02:40:09PM -0700, Nick Desaulniers wrote: > >> Fixes commit 208cbb325589 ("x86/irqflags: Provide a declaration for > >> native_save_fl") > >> > >> This should have been marked extern inline in order to pick up the out > >> of line definition in arch/x86/kernel/irqflags.S. > >> > >> Cc: stable@vger.kernel.org # 4.18, 4.14, 4.9, 4.4 > >> Reported-by: Ben Hutchings > >> Signed-off-by: Nick Desaulniers > >> --- > >> arch/x86/include/asm/irqflags.h | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h > >> index c14f2a74b2be..15450a675031 100644 > >> --- a/arch/x86/include/asm/irqflags.h > >> +++ b/arch/x86/include/asm/irqflags.h > >> @@ -33,7 +33,8 @@ extern inline unsigned long native_save_fl(void) > >> return flags; > >> } > >> > >> -static inline void native_restore_fl(unsigned long flags) > >> +extern inline void native_restore_fl(unsigned long flags); > >> +extern inline void native_restore_fl(unsigned long flags) > > > > This looks odd to me, but my coffee hasn't kicked in yet this morning. > > Why do you need both lines here? Shouldn't the actual function be > > sufficient? If not, a comment explaining this would be nice. > > Look just some lines further up: > > /* Declaration required for gcc < 4.9 to prevent > -Werror=missing-prototypes */ > extern inline unsigned long native_save_fl(void); > extern inline unsigned long native_save_fl(void) Ugh, my fault, I'll go shut up now... stupid gcc...