From: Mark Brown <broonie@kernel.org>
To: Kirill Marinushkin <kmarinushkin@birdec.tech>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
M R Swami Reddy <mr.swami.reddy@ti.com>,
Vishwas A Deshpande <vishwas.a.deshpande@ti.com>,
Kevin Cernekee <cernekee@chromium.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ASoC: pcm3060: Add codec driver
Date: Tue, 28 Aug 2018 20:40:45 +0100 [thread overview]
Message-ID: <20180828194045.GQ2414@sirena.org.uk> (raw)
In-Reply-To: <20180821165246.9479-2-kmarinushkin@birdec.tech>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
On Tue, Aug 21, 2018 at 06:52:46PM +0200, Kirill Marinushkin wrote:
This looks good apart from a few small stylistic things so I'll apply,
please send followup patches fixing these:
> +++ b/sound/soc/codecs/pcm3060-i2c.c
> @@ -0,0 +1,61 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * PCM3060 I2C driver
Please make the entire comment a C++ one, it makes this look more
intentional.
> + reg = (dai->id == PCM3060_DAI_ID_DAC ? PCM3060_REG67 : PCM3060_REG72);
Please rewrite this as a normal if statement to improve legibility,
there's some other ternery operator abuse in here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-08-28 19:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 16:52 [PATCH 0/1] " Kirill Marinushkin
2018-08-21 16:52 ` [PATCH 1/1] " Kirill Marinushkin
2018-08-28 19:40 ` Mark Brown [this message]
2018-08-28 21:42 ` [PATCH 1/2] ASoC: pcm3060: Improve stylistics of file comments Kirill Marinushkin
2018-08-28 21:42 ` [PATCH 2/2] ASoC: pcm3060: Improve legibility of if-statements Kirill Marinushkin
2018-08-29 11:31 ` Applied "ASoC: pcm3060: Improve legibility of if-statements" to the asoc tree Mark Brown
2018-08-29 11:31 ` Applied "ASoC: pcm3060: Improve stylistics of file comments" " Mark Brown
2018-08-28 20:28 ` Applied "ASoC: pcm3060: Add codec driver" " Mark Brown
2018-08-28 19:31 ` [PATCH 0/1] ASoC: pcm3060: Add codec driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180828194045.GQ2414@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cernekee@chromium.org \
--cc=kmarinushkin@birdec.tech \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mr.swami.reddy@ti.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.com \
--cc=vishwas.a.deshpande@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®