From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 886F7C433F5 for ; Wed, 29 Aug 2018 17:10:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 342B2205C9 for ; Wed, 29 Aug 2018 17:10:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 342B2205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728268AbeH2VIi (ORCPT ); Wed, 29 Aug 2018 17:08:38 -0400 Received: from mga17.intel.com ([192.55.52.151]:10638 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727704AbeH2VIh (ORCPT ); Wed, 29 Aug 2018 17:08:37 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2018 10:10:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,303,1531810800"; d="scan'208";a="81260276" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga002.fm.intel.com with ESMTP; 29 Aug 2018 10:10:41 -0700 Received: from andy by smile with local (Exim 4.91) (envelope-from ) id 1fv3zL-00039U-VB; Wed, 29 Aug 2018 20:10:39 +0300 Date: Wed, 29 Aug 2018 20:10:39 +0300 From: Andy Shevchenko To: Phil Edworthy Cc: Michael Turquette , Stephen Boyd , Russell King , Geert Uytterhoeven , Simon Horman , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 1/2] clk: Add of_clk_get_by_name_optional() function Message-ID: <20180829171039.GD11447@smile.fi.intel.com> References: <1533039060-18779-1-git-send-email-phil.edworthy@renesas.com> <1533039060-18779-2-git-send-email-phil.edworthy@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533039060-18779-2-git-send-email-phil.edworthy@renesas.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 31, 2018 at 01:10:59PM +0100, Phil Edworthy wrote: > Quite a few drivers get an optional clock, e.g. a clock required > to access peripheral's registers that is always enabled on some > devices. > > This function behaves the same as of_clk_get_by_name() except that > it will return NULL instead of -ENOENT. > + if (optional && (index == -EINVAL || index == -ENODATA || > + PTR_ERR(clk) == -ENOENT)) { A nit: I would rather rearrange this to be if (optional && (... || ... || ...)) { (disregard 80 characters limit for second line) -- With Best Regards, Andy Shevchenko