From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 02/21] staging:rtl8192u: Rename ChlWidth - Style
Date: Wed, 29 Aug 2018 21:35:28 +0100 [thread overview]
Message-ID: <20180829203547.15650-3-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180829203547.15650-1-johnfwhitmore@gmail.com>
Rename 'ChlWidth', member variable of the structure ht_capability_ele.
This change is to clear the checkpatch issue with CamelCase naming.
The bitfield's name has been changed to 'chl_width'.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
.../staging/rtl8192u/ieee80211/ieee80211_wx.c | 4 ++--
drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +-
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 ++++++++--------
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
index fa59c712c74b..514445dc542e 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
@@ -154,8 +154,8 @@ static inline char *rtl819x_translate_scan(struct ieee80211_device *ieee,
ht_cap = (struct ht_capability_ele *)&network->bssht.bdHTCapBuf[4];
else
ht_cap = (struct ht_capability_ele *)&network->bssht.bdHTCapBuf[0];
- is40M = (ht_cap->ChlWidth)?1:0;
- isShortGI = (ht_cap->ChlWidth)?
+ is40M = (ht_cap->chl_width)?1:0;
+ isShortGI = (ht_cap->chl_width)?
((ht_cap->ShortGI40Mhz)?1:0):
((ht_cap->ShortGI20Mhz)?1:0);
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
index 66a0274077d3..d79126853cd3 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
@@ -40,7 +40,7 @@ enum ht_extension_chan_offset {
struct ht_capability_ele {
//HT capability info
u8 not_used_adv_coding:1;
- u8 ChlWidth:1;
+ u8 chl_width:1;
u8 MimoPwrSave:2;
u8 GreenField:1;
u8 ShortGI20Mhz:1;
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index d7f73a5831da..d9c2a2df8d0e 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
@@ -142,7 +142,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString)
}
IEEE80211_DEBUG(IEEE80211_DL_HT, "<Log HT Capability>. Called by %s\n", TitleString);
- IEEE80211_DEBUG(IEEE80211_DL_HT, "\tSupported Channel Width = %s\n", (pCapELE->ChlWidth) ? "20MHz" : "20/40MHz");
+ IEEE80211_DEBUG(IEEE80211_DL_HT, "\tSupported Channel Width = %s\n", (pCapELE->chl_width) ? "20MHz" : "20/40MHz");
IEEE80211_DEBUG(IEEE80211_DL_HT, "\tSupport Short GI for 20M = %s\n", (pCapELE->ShortGI20Mhz) ? "YES" : "NO");
IEEE80211_DEBUG(IEEE80211_DL_HT, "\tSupport Short GI for 40M = %s\n", (pCapELE->ShortGI40Mhz) ? "YES" : "NO");
IEEE80211_DEBUG(IEEE80211_DL_HT, "\tSupport TX STBC = %s\n", (pCapELE->TxSTBC) ? "YES" : "NO");
@@ -230,7 +230,7 @@ static bool IsHTHalfNmode40Bandwidth(struct ieee80211_device *ieee)
retValue = false;
else if (!ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) // station in half n mode
retValue = false;
- else if (((struct ht_capability_ele *)(pHTInfo->PeerHTCapBuf))->ChlWidth) // ap support 40 bw
+ else if (((struct ht_capability_ele *)(pHTInfo->PeerHTCapBuf))->chl_width) // ap support 40 bw
retValue = true;
else
retValue = false;
@@ -551,17 +551,17 @@ void HTConstructCapabilityElement(struct ieee80211_device *ieee, u8 *posHTCap, u
//HT capability info
if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev))
- pCapELE->ChlWidth = 0;
+ pCapELE->chl_width = 0;
else
- pCapELE->ChlWidth = (pHT->bRegBW40MHz ? 1 : 0);
+ pCapELE->chl_width = (pHT->bRegBW40MHz ? 1 : 0);
-// pCapELE->ChlWidth = (pHT->bRegBW40MHz?1:0);
+// pCapELE->chl_width = (pHT->bRegBW40MHz?1:0);
pCapELE->MimoPwrSave = pHT->SelfMimoPs;
pCapELE->GreenField = 0; // This feature is not supported now!!
pCapELE->ShortGI20Mhz = 1; // We can receive Short GI!!
pCapELE->ShortGI40Mhz = 1; // We can receive Short GI!!
//DbgPrint("TX HT cap/info ele BW=%d SG20=%d SG40=%d\n\r",
- //pCapELE->ChlWidth, pCapELE->ShortGI20Mhz, pCapELE->ShortGI40Mhz);
+ //pCapELE->chl_width, pCapELE->ShortGI20Mhz, pCapELE->ShortGI40Mhz);
pCapELE->TxSTBC = 1;
pCapELE->RxSTBC = 0;
pCapELE->DelayBA = 0; // Do not support now!!
@@ -574,7 +574,7 @@ void HTConstructCapabilityElement(struct ieee80211_device *ieee, u8 *posHTCap, u
* MAC HT parameters info
* TODO: Nedd to take care of this part
*/
- IEEE80211_DEBUG(IEEE80211_DL_HT, "TX HT cap/info ele BW=%d MaxAMSDUSize:%d DssCCk:%d\n", pCapELE->ChlWidth, pCapELE->MaxAMSDUSize, pCapELE->DssCCk);
+ IEEE80211_DEBUG(IEEE80211_DL_HT, "TX HT cap/info ele BW=%d MaxAMSDUSize:%d DssCCk:%d\n", pCapELE->chl_width, pCapELE->MaxAMSDUSize, pCapELE->DssCCk);
if (IsEncrypt) {
pCapELE->MPDUDensity = 7; // 8us
@@ -935,7 +935,7 @@ void HTOnAssocRsp(struct ieee80211_device *ieee)
// IEEE80211_DEBUG_DATA(IEEE80211_DL_DATA|IEEE80211_DL_HT, pPeerHTInfo, sizeof(HT_INFORMATION_ELE));
// Config Supported Channel Width setting
//
- HTSetConnectBwMode(ieee, (enum ht_channel_width)(pPeerHTCap->ChlWidth), (enum ht_extension_chan_offset)(pPeerHTInfo->ExtChlOffset));
+ HTSetConnectBwMode(ieee, (enum ht_channel_width)(pPeerHTCap->chl_width), (enum ht_extension_chan_offset)(pPeerHTInfo->ExtChlOffset));
pHTInfo->bCurTxBW40MHz = (pPeerHTInfo->RecommemdedTxWidth == 1);
--
2.18.0
next prev parent reply other threads:[~2018-08-29 20:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 20:35 [PATCH 00/21] staging:rtl8192u: Refactor ht_capability_ele " John Whitmore
2018-08-29 20:35 ` [PATCH 01/21] staging:rtl8192u: Rename AdvCoding " John Whitmore
2018-08-29 21:14 ` Joe Perches
2018-08-29 21:21 ` Larry Finger
2018-08-29 21:55 ` John Whitmore
2018-08-30 22:34 ` Joe Perches
2018-08-31 22:27 ` John Whitmore
2018-08-30 8:23 ` Dan Carpenter
2018-08-30 8:26 ` Dan Carpenter
2018-08-30 21:35 ` John Whitmore
2018-08-31 7:24 ` Dan Carpenter
2018-09-10 15:08 ` Greg KH
2018-08-29 20:35 ` John Whitmore [this message]
2018-08-29 20:35 ` [PATCH 03/21] staging:rtl8192u: Rename MimoPwrSave " John Whitmore
2018-08-29 20:35 ` [PATCH 04/21] staging:rtl8192u: Rename GreenField " John Whitmore
2018-08-29 20:35 ` [PATCH 05/21] staging:rtl8192u: Rename ShortGI20Mhz " John Whitmore
2018-08-29 20:35 ` [PATCH 06/21] staging:rtl8192u: Rename ShortGI40Mhz " John Whitmore
2018-08-29 20:35 ` [PATCH 07/21] staging:rtl8192u: Rename TxSTBC " John Whitmore
2018-08-29 20:35 ` [PATCH 08/21] staging:rtl8192u: Rename RxSTBC " John Whitmore
2018-08-29 20:35 ` [PATCH 09/21] staging:rtl8192u: Rename DelayBA " John Whitmore
2018-08-29 20:35 ` [PATCH 10/21] staging:rtl8192u: Rename MaxAMSDUSize " John Whitmore
2018-08-29 20:35 ` [PATCH 11/21] staging:rtl8192u: Rename DssCCk " John Whitmore
2018-08-29 20:35 ` [PATCH 12/21] staging:rtl8192u: Rename PSMP " John Whitmore
2018-08-29 20:35 ` [PATCH 13/21] staging:rtl8192u: Rename Rsvd1 " John Whitmore
2018-08-29 20:35 ` [PATCH 14/21] staging:rtl8192u: Rename LSigTxopProtect " John Whitmore
2018-08-29 20:35 ` [PATCH 15/21] staging:rtl8192u: Rename MaxRxAMPDUFactor " John Whitmore
2018-08-29 20:35 ` [PATCH 16/21] staging:rtl8192u: Rename MPDUDensity " John Whitmore
2018-08-29 20:35 ` [PATCH 17/21] staging:rtl8192u: Rename Rsvd2 " John Whitmore
2018-08-29 20:35 ` [PATCH 18/21] staging:rtl8192u: Rename MCS " John Whitmore
2018-08-29 20:35 ` [PATCH 19/21] staging:rtl8192u: Rename ExtHTCapInfo " John Whitmore
2018-08-29 20:35 ` [PATCH 20/21] staging:rtl8192u: Rename TxBFCap " John Whitmore
2018-08-29 20:35 ` [PATCH 21/21] staging:rtl8192u: Rename ASCap " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829203547.15650-3-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome