mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
	josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
	rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
	fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 15/17] rcutorture: Print forward-progress test interval on error
Date: Wed, 29 Aug 2018 14:47:48 -0700	[thread overview]
Message-ID: <20180829214750.26972-15-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180829214722.GA23411@linux.vnet.ibm.com>

This commit prints the duration of the forward-progress test interval in
the case that no forward progress was observed as an aid to debugging.
When forward progress does happen, it prints out the number of
rcu_torture_writer() versions and grace periods that elapsed during the
forward-progress test.  At the end of the run, it also prints the number
of attempted and actual forward-progress tests.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 kernel/rcu/rcutorture.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index 50015b78a43f..7df8142a6a22 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -1702,6 +1702,7 @@ static void rcu_torture_fwd_prog_cb(struct rcu_head *rhp)
 static int rcu_torture_fwd_prog(void *args)
 {
 	unsigned long cver;
+	unsigned long dur;
 	struct fwd_cb_state fcs = { .stop = 0 };
 	unsigned long gps;
 	int idx;
@@ -1709,7 +1710,7 @@ static int rcu_torture_fwd_prog(void *args)
 	int sd4;
 	bool selfpropcb = false;
 	unsigned long stopat;
-	bool tested = false;
+	int tested = 0;
 	int tested_tries = 0;
 	static DEFINE_TORTURE_RANDOM(trs);
 
@@ -1727,7 +1728,8 @@ static int rcu_torture_fwd_prog(void *args)
 		gps = cur_ops->get_gp_seq();
 		sd = cur_ops->stall_dur() + 1;
 		sd4 = (sd + fwd_progress_div - 1) / fwd_progress_div;
-		stopat = jiffies + sd4 + torture_random(&trs) % (sd - sd4);
+		dur = sd4 + torture_random(&trs) % (sd - sd4);
+		stopat = jiffies + dur;
 		while (time_before(jiffies, stopat) && !torture_must_stop()) {
 			idx = cur_ops->readlock();
 			udelay(10);
@@ -1737,10 +1739,11 @@ static int rcu_torture_fwd_prog(void *args)
 		}
 		tested_tries++;
 		if (!time_before(jiffies, stopat) && !torture_must_stop()) {
-			tested = true;
-			cver = cver == READ_ONCE(rcu_torture_current_version);
+			tested++;
+			cver = READ_ONCE(rcu_torture_current_version) - cver;
 			gps = rcutorture_seq_diff(cur_ops->get_gp_seq(), gps);
-			WARN_ON_ONCE(cver && gps < 2);
+			WARN_ON(!cver && gps < 2);
+			pr_alert("%s: Duration %ld cver %ld gps %ld\n", __func__, dur, cver, gps);
 		}
 		/* Avoid slow periods, better to test when busy. */
 		stutter_wait("rcu_torture_fwd_prog");
@@ -1754,6 +1757,7 @@ static int rcu_torture_fwd_prog(void *args)
 	}
 	/* Short runs might not contain a valid forward-progress attempt. */
 	WARN_ON(!tested && tested_tries >= 5);
+	pr_alert("%s: tested %d tested_tries %d\n", __func__, tested, tested_tries);
 	torture_kthread_stopping("rcu_torture_fwd_prog");
 	return 0;
 }
-- 
2.17.1


  parent reply	other threads:[~2018-08-29 21:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 21:47 [PATCH tip/core/rcu 0/17] Torture-test changes for v4.20/v5.0 Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 01/17] torture: Stop overwriting Make.out file with obsolete version Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 02/17] rcutorture: Force occasional reader waits Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 03/17] rcutorture: Warn on bad torture type for built-in tests Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 04/17] rcuperf: Warn on bad perf " Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 05/17] rcutorture: Remove TREE06 and TREE08 from the default test list Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 06/17] rcutorture: Add forward-progress tests for RCU grace periods Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 07/17] rcutorture: Also use GP sequence to judge forward progress Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 08/17] rcutorture: Avoid no-test complaint if too few forward-progress tries Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 09/17] rcutorture: Vary forward-progress test interval Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 10/17] rcutorture: Add self-propagating callback to forward-progress testing Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 11/17] rcutorture: Increase rcu_read_delay() longdelay_ms Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 12/17] rcutorture: Limit reader duration if irq or bh disabled Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 13/17] rcutorture: Reduce priority of forward-progress testing Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 14/17] rcutorture: Adjust number of reader kthreads per CPU-hotplug operations Paul E. McKenney
2018-08-29 21:47 ` Paul E. McKenney [this message]
2018-08-29 21:47 ` [PATCH tip/core/rcu 16/17] rcutorture: Check GP completion at stutter end Paul E. McKenney
2018-08-29 21:47 ` [PATCH tip/core/rcu 17/17] rcutorture: Maintain self-propagating CB only during forward-progress test Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180829214750.26972-15-paulmck@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®