From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rui Miguel Silva <rmfrfs@gmail.com>,
linux-media@vger.kernel.org
Subject: [PATCH v2 2/2] media: ov2680: rename ov2680_v4l2_init() to ov2680_v4l2_register()
Date: Sat, 1 Sep 2018 14:46:30 +0200 [thread overview]
Message-ID: <20180901124630.14139-2-javierm@redhat.com> (raw)
In-Reply-To: <20180901124630.14139-1-javierm@redhat.com>
The function not only does initialization but also registers the subdevice
so change its name to make this more clear.
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
Changes in v2: None
drivers/media/i2c/ov2680.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov2680.c
index 3ccd584568fb..0e34e15b67b3 100644
--- a/drivers/media/i2c/ov2680.c
+++ b/drivers/media/i2c/ov2680.c
@@ -926,7 +926,7 @@ static int ov2680_mode_init(struct ov2680_dev *sensor)
return 0;
}
-static int ov2680_v4l2_init(struct ov2680_dev *sensor)
+static int ov2680_v4l2_register(struct ov2680_dev *sensor)
{
const struct v4l2_ctrl_ops *ops = &ov2680_ctrl_ops;
struct ov2680_ctrls *ctrls = &sensor->ctrls;
@@ -1092,7 +1092,7 @@ static int ov2680_probe(struct i2c_client *client)
if (ret < 0)
goto lock_destroy;
- ret = ov2680_v4l2_init(sensor);
+ ret = ov2680_v4l2_register(sensor);
if (ret < 0)
goto lock_destroy;
--
2.17.1
prev parent reply other threads:[~2018-09-01 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-01 12:46 [PATCH v2 1/2] media: ov2680: don't register the v4l2 subdevice before checking chip ID Javier Martinez Canillas
2018-09-01 12:46 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180901124630.14139-2-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rmfrfs@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®