From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: bmh@certi.org.br
Cc: John.Youn@synopsys.com, alexandre.torgue@st.com,
gregkh@linuxfoundation.org, hminas@synopsys.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH] usb: dwc2: Fix call location of dwc2_check_core_endianness
Date: Sun, 2 Sep 2018 00:43:48 +0200 [thread overview]
Message-ID: <20180901224348.25011-1-martin.blumenstingl@googlemail.com> (raw)
In-Reply-To: <20180827213638.18890-1-bmh@certi.org.br>
> Some SoC/IP as STM32F469, the snpsid can only be read after clock is
> enabled, otherwise it will read as 0, and the dwc2_check_core_endianness
> will assume the core and AHB have opposite endianness, leading to the
> following error:
>
> [ 1.976339] dwc2 50000000.usb: 50000000.usb supply vusb_d not found, using dummy regulator
> [ 1.986124] dwc2 50000000.usb: Linked as a consumer to regulator.0
> [ 1.992711] dwc2 50000000.usb: 50000000.usb supply vusb_a not found, using dummy regulator
> [ 2.003672] dwc2 50000000.usb: dwc2_core_reset: HANG! AHB Idle timeout GRSTCTL GRSTCTL_AHBIDLE
> [ 2.015176] dwc2: probe of 50000000.usb failed with error -16
>
> The proposed patch changes the location where dwc2_check_core_endianness
> is called, allowing the clock peripheral to be enabled first.
>
> Signed-off-by: Bruno Meirelles Herrera <bmh@certi.org.br>
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
This fixes the same error on my Odroid-C1 (Meson8b SoC).
Thank you for spotting and fixing this!
Regards
Martin
next prev parent reply other threads:[~2018-09-01 22:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 21:36 Bruno Meirelles Herrera
2018-09-01 22:43 ` Martin Blumenstingl [this message]
2018-09-03 8:09 ` Minas Harutyunyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180901224348.25011-1-martin.blumenstingl@googlemail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=John.Youn@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=bmh@certi.org.br \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®