From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Oleg Nesterov <oleg@redhat.com>,
Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH v2 3/3] x86/speculation: Enable cross-hyperthread spectre v2 STIBP mitigation
Date: Mon, 3 Sep 2018 16:36:56 +0200 [thread overview]
Message-ID: <20180903143656.GD24142@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180903143444.GW24124@hirez.programming.kicks-ass.net>
On Mon, Sep 03, 2018 at 04:34:44PM +0200, Peter Zijlstra wrote:
> On Mon, Sep 03, 2018 at 02:45:31PM +0200, Jiri Kosina wrote:
>
> > +static bool __init stibp_needed(void)
> > +{
> > + return (cpu_smt_control != CPU_SMT_NOT_SUPPORTED &&
> > + boot_cpu_has(X86_FEATURE_STIBP));
> > +}
>
> Should that not be:
>
> ((cpu_smt_control != CPU_SMT_NOT_SUPPORTED) ||
s/||/&&/
> (cpu_smt_control != CPU_SMT_FORCE_DISABLED)) &&
> boot_cpu_has(X86_FEATURE_STIBP);
>
> instead?
next prev parent reply other threads:[~2018-09-03 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 12:45 Jiri Kosina
2018-09-03 14:34 ` Peter Zijlstra
2018-09-03 14:36 ` Peter Zijlstra [this message]
2018-09-03 15:18 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903143656.GD24142@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aarcange@redhat.com \
--cc=dwmw@amazon.co.uk \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome