From: Peter Zijlstra <peterz@infradead.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Stephane Eranian <eranian@google.com>,
Jiri Olsa <jolsa@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [RFC] perf tool improvement requests
Date: Tue, 4 Sep 2018 16:17:24 +0200 [thread overview]
Message-ID: <20180904141724.GJ24124@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180904134218.GA5364@kernel.org>
On Tue, Sep 04, 2018 at 10:42:18AM -0300, Arnaldo Carvalho de Melo wrote:
> Then I need to get the DW_AT_location stuff parsed in pahole, so
> that with those offsets (second column, ending with :) with hits (first
> column, there its local period, but we can ask for some specific metric
> [1]), I'll be able to figure out what DW_TAG_variable or
> DW_TAG_formal_parameter is living there at that time, get the offset
> from the decoded instruction, say that xor, 0x138 offset from the type
> for %r15 at that offset (85) from kmem_cache_alloc, right?
I'm not sure how the DWARF location stuff works; it could be it already
includes the offset and decoding the instruction is not needed.
But yes, that's the basic idea; get DWARF to tell you what variable is
used at a certain IP.
> In a first milestone we'd have something like:
>
> perf annotate --hits function | pahole --annotate -C task_struct
>
> perf annotate --hits | pahole --annotate
Not sure keeping it two proglets makes sense, but whatever :-)
The alternative I suppose is making perf do the IP->struct::member
mapping and freed that to pahole, which then only uses it to annotate
the output.
Or, munge the entirety of pahole into perf..
next prev parent reply other threads:[~2018-09-04 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 2:45 Stephane Eranian
2018-09-04 7:10 ` Peter Zijlstra
2018-09-04 13:42 ` Arnaldo Carvalho de Melo
2018-09-04 13:53 ` Peter Zijlstra
2018-09-04 13:58 ` Jiri Olsa
2018-09-04 14:08 ` Arnaldo Carvalho de Melo
2018-09-04 14:17 ` Peter Zijlstra [this message]
2018-09-04 14:35 ` Arnaldo Carvalho de Melo
2018-09-04 15:50 ` Stephane Eranian
2018-09-04 16:05 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904141724.GJ24124@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome