From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 083DCC433F5 for ; Wed, 5 Sep 2018 07:51:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEB372073D for ; Wed, 5 Sep 2018 07:51:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Nu+3NcQI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEB372073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727802AbeIEMU1 (ORCPT ); Wed, 5 Sep 2018 08:20:27 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50394 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbeIEMU1 (ORCPT ); Wed, 5 Sep 2018 08:20:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=spSW9CKH/pSMgZh28Hnk8qV1dn+fO84v+Oblx+8OxH8=; b=Nu+3NcQIiTfY1q4mUzAPJq2W2 gSAySAZwI5cYJ4DqjBhjobjWHaEkOGWyil5zjctOaxSOIOHbRiFNlrMQFBm6g+1Eq5bAYpicPX/Iz kNZEoPxHPJHjPHqo3yGtPx7NdeZK0DYAo42ZndQWI8SN3wey41AwnFwh8VLCdOGNNuxdIxIZkaPQr k3nIhc8CYk0RL5XeJICvcHmBAQ7JjJMakA4ArvdIzr6XVW4Bv1mU1mJ+7lzfLmxgqv8X3tQ/+ewie wg/hT8yUldInZ669t+4peyrINqw+pHxsF7l/eco0o+XnoAMSMn2c/NPATM+zi/hXV3EYgBoYzCUeB 9G91xG8cg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fxSb0-0003B9-J6; Wed, 05 Sep 2018 07:51:26 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id C49D420191BFE; Wed, 5 Sep 2018 09:51:24 +0200 (CEST) Date: Wed, 5 Sep 2018 09:51:24 +0200 From: Peter Zijlstra To: Jiri Kosina Cc: Thomas Gleixner , Ingo Molnar , Josh Poimboeuf , Andrea Arcangeli , "Woodhouse, David" , Oleg Nesterov , Tim Chen , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 1/3] ptrace: Provide ___ptrace_may_access() that can be applied on arbitrary tasks Message-ID: <20180905075124.GM24124@hirez.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 04, 2018 at 04:40:57PM +0200, Jiri Kosina wrote: > From: Jiri Kosina > > Current ptrace_may_access() implementation assumes that the 'source' task is > always the caller (current). Note that now you 'fixed' the new user, this is still true. Which makes me think you do not in fact need this patch, right?