From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15199C433F5 for ; Thu, 6 Sep 2018 02:13:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE6102064D for ; Thu, 6 Sep 2018 02:13:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE6102064D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-sky.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726543AbeIFGqJ (ORCPT ); Thu, 6 Sep 2018 02:46:09 -0400 Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:38007 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725850AbeIFGqJ (ORCPT ); Thu, 6 Sep 2018 02:46:09 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.08469427|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e01l07440;MF=ren_guo@c-sky.com;NM=1;PH=DS;RN=12;RT=12;SR=0;TI=SMTPD_---.Cn4WQaU_1536199974; Received: from localhost(mailfrom:ren_guo@c-sky.com fp:SMTPD_---.Cn4WQaU_1536199974) by smtp.aliyun-inc.com(10.147.42.198); Thu, 06 Sep 2018 10:12:54 +0800 Date: Thu, 6 Sep 2018 10:12:54 +0800 From: Guo Ren To: Rob Herring Cc: linux-arch@vger.kernel.org, Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , Arnd Bergmann , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, thomas.petazzoni@bootlin.com, wbx@uclibc-ng.org, Greentime Hu Subject: Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc Message-ID: <20180906021254.GC29405@guoren-Inspiron-7460> References: <62dae1828ade759584bbf1507fe4a9e69d247a50.1536138304.git.ren_guo@c-sky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 05, 2018 at 07:43:10PM -0500, Rob Herring wrote: > On Wed, Sep 5, 2018 at 7:10 AM Guo Ren wrote: > > > > Signed-off-by: Guo Ren > > --- > > .../interrupt-controller/csky,apb-intc.txt | 45 ++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt > > new file mode 100644 > > index 0000000..faa482c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt > > @@ -0,0 +1,45 @@ > > +============================== > > +C-SKY APB Interrupt Controller > > +============================== > > + > > +C-SKY APB Interrupt Controller is a simple soc interrupt controller > > +on the apb bus and we only use it as root irq controller. > > + > > + - csky,apb-intc is used in a lot of csky fpgas and socs, it support 64 irq nums. > > + - csky,dual-apb-intc consists of 2 apb-intc and 128 irq nums supported. > > Can't this be described in DT as 2 csky,apb-intc nodes? In detail, dual-apb-intc is not the same as two apb-intc, so I still want to name them separately, so I will keep this and it is clearer. > > + - compatible > > + Usage: required > > + Value type: > > + Definition: must be "csky,apb-intc" > > + "csky,dual-apb-intc" > > + "csky,gx6605s-intc" > > + - interrupt-cells > > #interrupt-cells Yes, I forgot #. - #interrupt-cells > > + Usage: required > > + Value type: > > + Definition: must be <1> > > No edge or level configuration? No, also no support in hardware. > > + > > + intc: interrupt-controller { > > Needs a unit-address. Ok, change it to: intc: interrupt-controller@0x00500000 { Guo Ren