From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E6CC4321E for ; Fri, 7 Sep 2018 21:47:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F4AE206BB for ; Fri, 7 Sep 2018 21:47:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F4AE206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731286AbeIHCaA (ORCPT ); Fri, 7 Sep 2018 22:30:00 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:53280 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728406AbeIHC37 (ORCPT ); Fri, 7 Sep 2018 22:29:59 -0400 Received: from localhost (unknown [207.32.164.225]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 05889147BB32C; Fri, 7 Sep 2018 14:47:02 -0700 (PDT) Date: Fri, 07 Sep 2018 14:46:59 -0700 (PDT) Message-Id: <20180907.144659.284526279757617907.davem@davemloft.net> To: igor.stoppa@gmail.com Cc: huangdaode@hisilicon.com, igor.stoppa@huawei.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ethernet: hnae: add unlikely() to assert() From: David Miller In-Reply-To: <20180907172650.29408-1-igor.stoppa@huawei.com> References: <20180907172650.29408-1-igor.stoppa@huawei.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 07 Sep 2018 14:47:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Igor Stoppa Date: Fri, 7 Sep 2018 20:26:50 +0300 > The assert() condition is likely to be true. Worse than that is that drivers should not be definiting their own private "assert()" macro. I'd rather have that fixed instead. We have tons of standard kernel facilities that do what they are trying to do here, without overloading the standard C namespace in this way.